Skip to content

Commit 197201c

Browse files
committed
refactor: enable only for browser tests
1 parent 5c50d7a commit 197201c

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,9 @@ jobs:
150150
run: pnpm install
151151

152152
- name: 🏗️ Build project
153-
run: pnpm build:playwright
153+
run: pnpm build:test
154+
env:
155+
VALIDATE_HTML: true
154156

155157
- name: 🖥️ Test project (browser)
156158
run: pnpm test:browser:prebuilt
@@ -178,7 +180,7 @@ jobs:
178180
run: pnpm install
179181

180182
- name: 🏗️ Build project
181-
run: pnpm build:playwright
183+
run: pnpm build:test
182184

183185
- name: ♿ Accessibility audit (Lighthouse - ${{ matrix.mode }} mode)
184186
run: ./scripts/lighthouse-a11y.sh

nuxt.config.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import process from 'node:process'
22
import { currentLocales } from './config/i18n'
3-
4-
// log node env
5-
console.log(`Running Nuxt in ${process.env.NODE_ENV} mode`)
3+
import { isCI, provider } from 'std-env'
64

75
export default defineNuxtConfig({
86
modules: [
@@ -21,7 +19,7 @@ export default defineNuxtConfig({
2119
})
2220
},
2321
'@unocss/nuxt',
24-
process.env.NODE_ENV === 'test' ? null : '@nuxtjs/html-validator',
22+
'@nuxtjs/html-validator',
2523
'@nuxt/scripts',
2624
'@nuxt/a11y',
2725
'@nuxt/fonts',
@@ -198,6 +196,7 @@ export default defineNuxtConfig({
198196
},
199197

200198
htmlValidator: {
199+
enabled: !isCI || (provider !== 'vercel' && !!process.env.VALIDATE_HTML),
201200
failOnError: true,
202201
},
203202

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
},
1212
"scripts": {
1313
"build": "nuxt build",
14-
"build:playwright": "NODE_ENV=test pnpm build",
1514
"build:lunaria": "node ./lunaria/lunaria.ts",
15+
"build:test": "NODE_ENV=test pnpm build",
1616
"dev": "nuxt dev",
1717
"dev:docs": "pnpm run --filter npmx-docs dev --port=3001",
1818
"i18n:check": "node scripts/compare-translations.ts",
@@ -30,10 +30,10 @@
3030
"generate:fixtures": "node scripts/generate-fixtures.ts",
3131
"generate:lexicons": "lex build --lexicons lexicons --out shared/types/lexicons --clear",
3232
"test": "vite test",
33-
"test:browser": "pnpm build:playwright && pnpm test:browser:prebuilt",
33+
"test:browser": "pnpm build:test && pnpm test:browser:prebuilt",
3434
"test:browser:prebuilt": "playwright test",
35-
"test:browser:ui": "pnpm build:playwright && pnpm test:browser:prebuilt --ui",
36-
"test:browser:update": "pnpm build:playwright && pnpm test:browser:prebuilt --update-snapshots",
35+
"test:browser:ui": "pnpm build:test && pnpm test:browser:prebuilt --ui",
36+
"test:browser:update": "pnpm build:test && pnpm test:browser:prebuilt --update-snapshots",
3737
"test:nuxt": "vite test --project nuxt",
3838
"test:types": "pnpm generate:lexicons && nuxt prepare && vue-tsc -b --noEmit && pnpm --filter npmx-connector test:types",
3939
"test:unit": "vite test --project unit",

0 commit comments

Comments
 (0)