Moved to be a bit cleaner update api

Author: fatfingers23

server/api/auth/session.delete.ts

@@ -1,5 +1,7 @@
 export default eventHandlerWithOAuthSession(async (event, oAuthSession, serverSession) => {
-  await Promise.all([oAuthSession?.signOut(), serverSession.clear()])
-
+  // Even tho the signOut also clears part of the server cache should be done in order
+  // to let the oAuth package do any other clean up it may need
+  await oAuthSession?.signOut()
+  await serverSession.clear()
   return 'Session cleared'
 })

server/utils/atproto/oauth-session-store.ts

@@ -17,12 +17,14 @@ export class OAuthSessionStore implements NodeSavedSessionStore {
 
   async set(_key: string, val: NodeSavedSession) {
     // We are ignoring the key since the mapping is already done in the session
-    this.session.data.oauthSession = val
-    await this.session.update(this.session.data)
+    await this.session.update({
+      oauthSession: val,
+    })
   }
 
   async del() {
-    this.session.data.oauthSession = undefined
-    await this.session.update(this.session.data)
+    await this.session.update({
+      oauthSession: undefined,
+    })
   }
 }

server/utils/atproto/oauth-state-store.ts

@@ -17,12 +17,14 @@ export class OAuthStateStore implements NodeSavedStateStore {
 
   async set(_key: string, val: NodeSavedState) {
     // We are ignoring the key since the mapping is already done in the session
-    this.session.data.oauthState = val
-    await this.session.update(this.session.data)
+    await this.session.update({
+      oauthState: val,
+    })
   }
 
   async del() {
-    this.session.data.oauthState = undefined
-    await this.session.update(this.session.data)
+    await this.session.update({
+      oauthState: undefined,
+    })
   }
 }