fix: handle deferred 404

Author: danielroe

app/composables/npm/useResolvedVersion.ts

@@ -15,6 +15,6 @@ export function useResolvedVersion(
       const data = await $fetch<ResolvedPackageVersion>(url)
       return data.version
     },
-    { default: () => null },
+    { default: () => undefined },
   )
 }

app/pages/package/[[org]]/[name].vue

@@ -215,10 +215,18 @@ const { data: resolvedVersion, status: resolvedStatus } = await useResolvedVersi
   requestedVersion,
 )
 
+if (import.meta.server && !resolvedVersion.value && resolvedStatus.value === 'success') {
+  throw createError({
+    statusCode: 404,
+    statusMessage: $t('package.not_found'),
+    message: $t('package.not_found_message'),
+  })
+}
+
 watch(
   [resolvedStatus, resolvedVersion],
   ([status, version]) => {
-    if (version === null && status === 'success') {
+    if (!version && status === 'success') {
       showError({
         statusCode: 404,
         statusMessage: $t('package.not_found'),

modules/isr-fallback.ts

@@ -31,7 +31,7 @@ export default defineNuxtModule({
           const outputPath = resolve(nitro.options.output.serverDir, '..', path, htmlFallback)
           mkdirSync(resolve(nitro.options.output.serverDir, '..', path), { recursive: true })
           writeFileSync(outputPath, spaTemplate)
-          writeFileSync(outputPath.replace(htmlFallback, jsonFallback), '[{}]')
+          writeFileSync(outputPath.replace(htmlFallback, jsonFallback), '[]')
         }
       })
     })