Skip to content

Commit 1e8088e

Browse files
committed
chore: apply a11y suggestions
Co-authored-by: Nathan Knowler <Nathan Knowler>
1 parent d36a691 commit 1e8088e

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

app/pages/about.vue

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,6 @@ onBeforeUnmount(() => {
355355
:aria-expanded="
356356
isMounted && activeContributor?.id === contributor.id ? 'true' : undefined
357357
"
358-
:aria-haspopup="isMounted && isExpandable(contributor) ? 'true' : undefined"
359358
:aria-label="
360359
isExpandable(contributor)
361360
? getAriaLabel(contributor)
@@ -382,10 +381,9 @@ onBeforeUnmount(() => {
382381
</button>
383382

384383
<Transition name="pop">
385-
<div
384+
<article
386385
v-if="isExpandable(contributor) && activeContributor?.id === contributor.id"
387386
data-popover-panel
388-
role="tooltip"
389387
class="contributor-popover"
390388
:style="{
391389
top: `${popoverPos.top}px`,
@@ -399,11 +397,11 @@ onBeforeUnmount(() => {
399397
class="flex flex-col gap-y-3 w-64 rounded-xl border border-border-subtle bg-bg-elevated p-4 shadow-2xl text-start"
400398
>
401399
<div class="flex flex-col gap-2 min-w-0">
402-
<span
400+
<hgroup
403401
class="w-full font-sans font-bold text-fg leading-tight truncate block"
404402
>
405-
{{ contributor.name || contributor.login }}
406-
</span>
403+
<h3>{{ contributor.name || contributor.login }}</h3>
404+
</hgroup>
407405
<div
408406
v-if="roleLabels[contributor.role]"
409407
class="font-mono text-3xs uppercase tracking-wider text-accent font-bold"
@@ -525,7 +523,7 @@ onBeforeUnmount(() => {
525523
</a>
526524
</div>
527525
</div>
528-
</div>
526+
</article>
529527
</Transition>
530528
</li>
531529
</ul>

0 commit comments

Comments
 (0)