Skip to content

Commit 28d2d0f

Browse files
committed
fix: tests
1 parent f4633d9 commit 28d2d0f

File tree

4 files changed

+22
-12
lines changed

4 files changed

+22
-12
lines changed

app/components/Header/ConnectorModal.vue

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,12 @@ function startAuthPolling() {
2626
stopAuthPolling()
2727
let remaining = AUTH_POLL_COUNT
2828
authPollTimer = setInterval(async () => {
29-
await refreshState()
29+
try {
30+
await refreshState()
31+
} catch {
32+
stopAuthPolling()
33+
return
34+
}
3035
remaining--
3136
if (remaining <= 0) {
3237
stopAuthPolling()
@@ -128,7 +133,6 @@ function handleDisconnect() {
128133
:label="$t('connector.modal.auto_open_url')"
129134
v-model="settings.connector.autoOpenURL"
130135
:class="!settings.connector.webAuth ? 'opacity-50 pointer-events-none' : ''"
131-
:aria-disabled="!settings.connector.webAuth"
132136
/>
133137
</div>
134138

@@ -145,7 +149,7 @@ function handleDisconnect() {
145149
<button
146150
v-if="authUrl"
147151
type="button"
148-
class="flex items-center justify-center gap-2 w-full px-4 py-2 font-mono text-sm text-accent bg-accent/10 border border-accent/30 rounded-md transition-colors duration-200 hover:bg-accent/20 focus-visible:outline-accent/70"
152+
class="flex items-center justify-center gap-2 w-full px-4 py-2 font-mono text-sm text-accent bg-accent/10 border border-accent/30 rounded-md transition-colors duration-200 hover:bg-accent/20"
149153
@click="handleOpenAuthUrl"
150154
>
151155
<span class="i-carbon:launch w-4 h-4" aria-hidden="true" />
@@ -289,7 +293,6 @@ function handleDisconnect() {
289293
:label="$t('connector.modal.auto_open_url')"
290294
v-model="settings.connector.autoOpenURL"
291295
:class="!settings.connector.webAuth ? 'opacity-50 pointer-events-none' : ''"
292-
:aria-disabled="!settings.connector.webAuth"
293296
/>
294297
</div>
295298
</div>

app/components/Org/OperationsQueue.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ watch(isExecuting, executing => {
281281
v-if="settings.connector.webAuth"
282282
type="button"
283283
:disabled="isExecuting"
284-
class="w-full mt-2 px-3 py-2 font-mono text-xs text-fg bg-bg-subtle border border-border rounded transition-all duration-200 hover:text-fg hover:border-border-hover disabled:opacity-50 disabled:cursor-not-allowed focus-visible:outline-accent/70"
284+
class="w-full mt-2 px-3 py-2 font-mono text-xs text-fg bg-bg-subtle border border-border rounded transition-all duration-200 hover:text-fg hover:border-border-hover disabled:opacity-50 disabled:cursor-not-allowed"
285285
@click="handleRetryWithWebAuth"
286286
>
287287
{{ isExecuting ? $t('operations.queue.retrying') : $t('operations.queue.retry_web_auth') }}

cli/src/node-pty.d.ts

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,24 @@
1-
// @lydell/node-pty package.json does not export its types so for nodenext target we need to add them (very minimal version)
1+
// @lydell/node-pty package.json does not export its types so for nodenext target we need to add them
22
declare module '@lydell/node-pty' {
3+
interface IDisposable {
4+
dispose(): void
5+
}
6+
7+
interface IEvent<T> {
8+
(listener: (e: T) => any): IDisposable
9+
}
10+
311
interface IPty {
412
readonly pid: number
5-
readonly onData: (listener: (data: string) => void) => { dispose(): void }
6-
readonly onExit: (listener: (e: { exitCode: number; signal?: number }) => void) => {
7-
dispose(): void
8-
}
9-
write(data: string): void
13+
readonly onData: IEvent<string>
14+
readonly onExit: IEvent<{ exitCode: number; signal?: number }>
15+
write(data: string | Buffer): void
1016
kill(signal?: string): void
1117
}
1218

1319
export function spawn(
1420
file: string,
15-
args: string[],
21+
args: string[] | string,
1622
options: {
1723
name?: string
1824
cols?: number

cli/src/npm-client.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import './node-pty.d.ts'
12
import crypto from 'node:crypto'
23
import process from 'node:process'
34
import { execFile } from 'node:child_process'

0 commit comments

Comments
 (0)