Skip to content

Commit 2cdd112

Browse files
committed
refactor: use justify-content: space-between in AppFooter
In #318, `justify-content: space-between` was removed unnecessary and a hack was introduced in its place. Flexbox layout already is directionality/writing-mode aware and `justify-content` has no bearing on the order of items, just their placement within the “main” axis. This switches back to what it was before which is simpler as it doesn’t add extra elements, presentational elements that are hidden with ARIA.
1 parent 10f6aba commit 2cdd112

1 file changed

Lines changed: 11 additions & 12 deletions

File tree

app/components/AppFooter.vue

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,49 @@
11
<template>
22
<footer class="border-t border-border mt-auto">
33
<div class="container py-3 sm:py-8 flex flex-col gap-2 sm:gap-4 text-fg-subtle text-sm">
4-
<div class="flex flex-col sm:flex-row items-center justify-start gap-2 sm:gap-4">
4+
<div class="flex flex-col sm:flex-row items-center justify-between gap-2 sm:gap-4">
55
<p class="font-mono m-0 hidden sm:block">{{ $t('tagline') }}</p>
6-
<span aria-hidden="true" class="flex-shrink-1 flex-grow-1" />
7-
<div class="flex items-center justify-start gap-3 sm:gap-6">
6+
<div class="flex items-center gap-3 sm:gap-6">
87
<NuxtLink
98
to="/about"
109
class="link-subtle font-mono text-xs min-h-8 sm:min-h-11 flex items-center"
1110
>
12-
<span>{{ $t('footer.about') }}</span>
11+
{{ $t('footer.about') }}
1312
</NuxtLink>
1413
<a
1514
href="https://docs.npmx.dev"
1615
target="_blank"
1716
rel="noopener noreferrer"
18-
class="link-subtle font-mono text-xs min-h-8 sm:min-h-11 flex items-center justify-start gap-1"
17+
class="link-subtle font-mono text-xs min-h-8 sm:min-h-11 flex items-center gap-1"
1918
>
20-
<span>{{ $t('footer.docs') }}</span>
19+
{{ $t('footer.docs') }}
2120
<span class="i-carbon:launch rtl-flip w-3 h-3" aria-hidden="true" />
2221
</a>
2322
<a
2423
href="https://repo.npmx.dev"
2524
target="_blank"
2625
rel="noopener noreferrer"
27-
class="link-subtle font-mono text-xs min-h-8 sm:min-h-11 flex justify-start items-center gap-1"
26+
class="link-subtle font-mono text-xs min-h-8 sm:min-h-11 flex items-center gap-1"
2827
>
29-
<span>{{ $t('footer.source') }}</span>
28+
{{ $t('footer.source') }}
3029
<span class="i-carbon:launch rtl-flip w-3 h-3" aria-hidden="true" />
3130
</a>
3231
<a
3332
href="https://social.npmx.dev"
3433
target="_blank"
3534
rel="noopener noreferrer"
36-
class="link-subtle font-mono text-xs min-h-8 sm:min-h-11 flex items-center justify-start gap-1"
35+
class="link-subtle font-mono text-xs min-h-8 sm:min-h-11 flex items-center gap-1"
3736
>
38-
<span>{{ $t('footer.social') }}</span>
37+
{{ $t('footer.social') }}
3938
<span class="i-carbon:launch rtl-flip w-3 h-3" aria-hidden="true" />
4039
</a>
4140
<a
4241
href="https://chat.npmx.dev"
4342
target="_blank"
4443
rel="noopener noreferrer"
45-
class="link-subtle font-mono text-xs min-h-8 sm:min-h-11 flex items-center justify-start gap-1"
44+
class="link-subtle font-mono text-xs min-h-8 sm:min-h-11 flex items-center gap-1"
4645
>
47-
<span>{{ $t('footer.chat') }}</span>
46+
{{ $t('footer.chat') }}
4847
<span class="i-carbon:launch rtl-flip w-3 h-3" aria-hidden="true" />
4948
</a>
5049
</div>

0 commit comments

Comments
 (0)