fix(ui): handle non-matching URLs in extractPackageFromRef

danielroe · danielroe · commit 2e1bbd70ccc7 · 2026-02-27T12:25:24.000Z
diff --git a/app/components/Package/LikeCard.vue b/app/components/Package/LikeCard.vue
@@ -8,8 +8,7 @@ const props = defineProps<{
 const compactNumberFormatter = useCompactNumberFormatter()
 
 function extractPackageFromRef(ref: string) {
-  const { pkg } = /https:\/\/npmx.dev\/package\/(?<pkg>.*)/.exec(ref).groups
-  return pkg
+  return /https:\/\/npmx.dev\/package\/(?<pkg>.*)/.exec(ref)?.groups?.pkg ?? ref
 }
 
 const name = computed(() => extractPackageFromRef(props.packageUrl))

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,7 @@ const props = defineProps<{`
`8`	`8`	`const compactNumberFormatter = useCompactNumberFormatter()`
`9`	`9`
`10`	`10`	`function extractPackageFromRef(ref: string) {`
`11`		`- const { pkg } = /https:\/\/npmx.dev\/package\/(?<pkg>.*)/.exec(ref).groups`
`12`		`- return pkg`
	`11`	`+ return /https:\/\/npmx.dev\/package\/(?<pkg>.*)/.exec(ref)?.groups?.pkg ?? ref`
`13`	`12`	`}`
`14`	`13`
`15`	`14`	`const name = computed(() => extractPackageFromRef(props.packageUrl))`