Skip to content

Commit 314175b

Browse files
committed
fix: some a11y issues
1 parent c190b0e commit 314175b

4 files changed

Lines changed: 10 additions & 6 deletions

File tree

app/components/ConnectorStatus.client.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ const ariaLabel = computed(() => {
6161
v-if="isConnected && avatar"
6262
:src="avatar"
6363
:alt="`${npmUser}'s avatar`"
64+
width="24"
65+
height="24"
6466
class="w-6 h-6 rounded-full"
6567
/>
6668
<!-- Status dot (when not connected or no avatar) -->

app/components/HeaderOrgsDropdown.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ function handleKeydown(event: KeyboardEvent) {
6565
<span
6666
class="i-carbon-chevron-down w-3 h-3 transition-transform duration-200"
6767
:class="{ 'rotate-180': isOpen }"
68+
aria-hidden="true"
6869
/>
6970
</NuxtLink>
7071

@@ -83,7 +84,7 @@ function handleKeydown(event: KeyboardEvent) {
8384
</div>
8485

8586
<div v-if="isLoading" class="px-3 py-4 text-center">
86-
<span class="text-fg-muted text-sm">Loading...</span>
87+
<span class="text-fg-muted text-sm">Loading</span>
8788
</div>
8889

8990
<div v-else-if="error" class="px-3 py-4 text-center">
@@ -111,7 +112,7 @@ function handleKeydown(event: KeyboardEvent) {
111112
class="link-subtle font-mono text-xs inline-flex items-center gap-1"
112113
>
113114
View all
114-
<span class="i-carbon-arrow-right w-3 h-3" />
115+
<span class="i-carbon-arrow-right w-3 h-3" aria-hidden="true" />
115116
</NuxtLink>
116117
</div>
117118
</div>

app/components/HeaderPackagesDropdown.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ function handleKeydown(event: KeyboardEvent) {
6565
<span
6666
class="i-carbon-chevron-down w-3 h-3 transition-transform duration-200"
6767
:class="{ 'rotate-180': isOpen }"
68+
aria-hidden="true"
6869
/>
6970
</NuxtLink>
7071

@@ -83,7 +84,7 @@ function handleKeydown(event: KeyboardEvent) {
8384
</div>
8485

8586
<div v-if="isLoading" class="px-3 py-4 text-center">
86-
<span class="text-fg-muted text-sm">Loading...</span>
87+
<span class="text-fg-muted text-sm">Loading</span>
8788
</div>
8889

8990
<div v-else-if="error" class="px-3 py-4 text-center">
@@ -111,7 +112,7 @@ function handleKeydown(event: KeyboardEvent) {
111112
class="link-subtle font-mono text-xs inline-flex items-center gap-1"
112113
>
113114
View all
114-
<span class="i-carbon-arrow-right w-3 h-3" />
115+
<span class="i-carbon-arrow-right w-3 h-3" aria-hidden="true" />
115116
</NuxtLink>
116117
</div>
117118
</div>

app/pages/~[username]/orgs.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ useSeoMeta({
129129
:to="`/~${username}`"
130130
class="link-subtle font-mono text-sm inline-flex items-center gap-1.5"
131131
>
132-
<span class="i-carbon-arrow-left w-4 h-4" />
132+
<span class="i-carbon-arrow-left w-4 h-4" aria-hidden="true" />
133133
Back to profile
134134
</NuxtLink>
135135
</nav>
@@ -210,7 +210,7 @@ useSeoMeta({
210210
<!-- Stats -->
211211
<div class="flex items-center gap-4 text-sm text-fg-muted">
212212
<div class="flex items-center gap-1.5">
213-
<span class="i-carbon-cube w-4 h-4" />
213+
<span class="i-carbon-cube w-4 h-4" aria-hidden="true" />
214214
<span v-if="org.packageCount !== null">
215215
{{ org.packageCount }} package{{ org.packageCount === 1 ? '' : 's' }}
216216
</span>

0 commit comments

Comments
 (0)