Skip to content

Commit 338b86a

Browse files
authored
fix(i18n,ui): add search page title and description (#872)
1 parent bdaaa2c commit 338b86a

File tree

7 files changed

+36
-3
lines changed

7 files changed

+36
-3
lines changed

app/pages/search.vue

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -581,12 +581,21 @@ function handleResultsKeydown(e: KeyboardEvent) {
581581
onKeyDown(['ArrowDown', 'ArrowUp', 'Enter'], handleResultsKeydown)
582582
583583
useSeoMeta({
584-
title: () => (query.value ? `Search: ${query.value} - npmx` : 'Search Packages - npmx'),
584+
title: () =>
585+
`${query.value ? $t('search.title_search', { search: query.value }) : $t('search.title_packages')} - npmx`,
586+
description: () =>
587+
query.value
588+
? $t('search.meta_description', { search: query.value })
589+
: $t('search.meta_description_packages'),
585590
})
586591
587592
defineOgImageComponent('Default', {
588-
title: 'npmx',
589-
description: () => (query.value ? `Search results for "${query.value}"` : 'Search npm packages'),
593+
title: () =>
594+
`${query.value ? $t('search.title_search', { search: query.value }) : $t('search.title_packages')} - npmx`,
595+
description: () =>
596+
query.value
597+
? $t('search.meta_description', { search: query.value })
598+
: $t('search.meta_description_packages'),
590599
primaryColor: '#60a5fa',
591600
})
592601
</script>

i18n/locales/en.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
"updating": "(updating...)",
2929
"no_results": "No packages found for \"{query}\"",
3030
"title": "search",
31+
"title_search": "search: {search}",
32+
"title_packages": "search packages",
33+
"meta_description": "Search results for '{search}'",
34+
"meta_description_packages": "Search npm packages",
3135
"not_taken": "{name} is not taken",
3236
"claim_prompt": "Claim this package name on npm",
3337
"claim_button": "Claim \"{name}\"",

i18n/locales/es.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
"updating": "(actualizando...)",
2929
"no_results": "No se encontraron paquetes para \"{query}\"",
3030
"title": "búsqueda",
31+
"title_search": "búsqueda: {search}",
32+
"title_packages": "búsqueda de paquetes",
33+
"meta_description": "Resultado de la búsqueda para '{search}'",
34+
"meta_description_packages": "Búsqueda de paquetes npm",
3135
"not_taken": "{name} no está ocupado",
3236
"claim_prompt": "Reclamar este nombre de paquete en npm",
3337
"claim_button": "Reclamar \"{name}\"",

lunaria/files/en-GB.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
"updating": "(updating...)",
2929
"no_results": "No packages found for \"{query}\"",
3030
"title": "search",
31+
"title_search": "search: {search}",
32+
"title_packages": "search packages",
33+
"meta_description": "Search results for '{search}'",
34+
"meta_description_packages": "Search npm packages",
3135
"not_taken": "{name} is not taken",
3236
"claim_prompt": "Claim this package name on npm",
3337
"claim_button": "Claim \"{name}\"",

lunaria/files/en-US.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
"updating": "(updating...)",
2929
"no_results": "No packages found for \"{query}\"",
3030
"title": "search",
31+
"title_search": "search: {search}",
32+
"title_packages": "search packages",
33+
"meta_description": "Search results for '{search}'",
34+
"meta_description_packages": "Search npm packages",
3135
"not_taken": "{name} is not taken",
3236
"claim_prompt": "Claim this package name on npm",
3337
"claim_button": "Claim \"{name}\"",

lunaria/files/es-419.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
"updating": "(actualizando...)",
2929
"no_results": "No se encontraron paquetes para \"{query}\"",
3030
"title": "búsqueda",
31+
"title_search": "búsqueda: {search}",
32+
"title_packages": "búsqueda de paquetes",
33+
"meta_description": "Resultado de la búsqueda para '{search}'",
34+
"meta_description_packages": "Búsqueda de paquetes npm",
3135
"not_taken": "{name} no está ocupado",
3236
"claim_prompt": "Reclamar este nombre de paquete en npm",
3337
"claim_button": "Reclamar \"{name}\"",

lunaria/files/es-ES.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
"updating": "(actualizando...)",
2929
"no_results": "No se encontraron paquetes para \"{query}\"",
3030
"title": "búsqueda",
31+
"title_search": "búsqueda: {search}",
32+
"title_packages": "búsqueda de paquetes",
33+
"meta_description": "Resultado de la búsqueda para '{search}'",
34+
"meta_description_packages": "Búsqueda de paquetes npm",
3135
"not_taken": "{name} no está ocupado",
3236
"claim_prompt": "Reclamar este nombre de paquete en npm",
3337
"claim_button": "Reclamar \"{name}\"",

0 commit comments

Comments
 (0)