Skip to content

Commit 3959303

Browse files
committed
fix: refactor away i18n key interpolation
1 parent 3e2e8a5 commit 3959303

File tree

4 files changed

+33
-16
lines changed

4 files changed

+33
-16
lines changed

app/components/Diff/ViewerPanel.vue

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,12 @@ useCommandPaletteContextCommands(
104104
action: () => {
105105
mergeModifiedLines.value = !mergeModifiedLines.value
106106
announce(
107-
$t(
108-
mergeModifiedLines.value
109-
? 'command_palette.announcements.setting_on'
110-
: 'command_palette.announcements.setting_off',
111-
{ setting: $t('command_palette.diff.merge_modified_lines') },
112-
),
107+
$t('command_palette.announcements.setting_toggled', {
108+
setting: $t('command_palette.diff.merge_modified_lines'),
109+
state: $t(
110+
mergeModifiedLines.value ? 'command_palette.state.on' : 'command_palette.state.off',
111+
),
112+
}),
113113
)
114114
},
115115
},
@@ -123,12 +123,10 @@ useCommandPaletteContextCommands(
123123
action: () => {
124124
wordWrap.value = !wordWrap.value
125125
announce(
126-
$t(
127-
wordWrap.value
128-
? 'command_palette.announcements.setting_on'
129-
: 'command_palette.announcements.setting_off',
130-
{ setting: $t('command_palette.diff.word_wrap') },
131-
),
126+
$t('command_palette.announcements.setting_toggled', {
127+
setting: $t('command_palette.diff.word_wrap'),
128+
state: $t(wordWrap.value ? 'command_palette.state.on' : 'command_palette.state.off'),
129+
}),
132130
)
133131
},
134132
},

i18n/locales/en.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,7 @@
183183
"facets_all_selected": "All facets selected.",
184184
"facets_all_deselected": "All facets deselected.",
185185
"view_switched": "Switched to {view} view.",
186-
"setting_on": "{setting} on.",
187-
"setting_off": "{setting} off."
186+
"setting_toggled": "{setting} {state}."
188187
}
189188
},
190189
"nav": {

i18n/locales/fr-FR.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,7 @@
183183
"facets_all_selected": "Toutes les facettes sélectionnées.",
184184
"facets_all_deselected": "Toutes les facettes désélectionnées.",
185185
"view_switched": "Vue {view} activée.",
186-
"setting_on": "{setting} activé.",
187-
"setting_off": "{setting} désactivé."
186+
"setting_toggled": "{setting} {state}."
188187
}
189188
},
190189
"nav": {

i18n/schema.json

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -534,6 +534,27 @@
534534
},
535535
"download_started": {
536536
"type": "string"
537+
},
538+
"copied_to_clipboard": {
539+
"type": "string"
540+
},
541+
"npm_disconnected": {
542+
"type": "string"
543+
},
544+
"atmosphere_disconnected": {
545+
"type": "string"
546+
},
547+
"facets_all_selected": {
548+
"type": "string"
549+
},
550+
"facets_all_deselected": {
551+
"type": "string"
552+
},
553+
"view_switched": {
554+
"type": "string"
555+
},
556+
"setting_toggled": {
557+
"type": "string"
537558
}
538559
},
539560
"additionalProperties": false

0 commit comments

Comments
 (0)