Skip to content

Commit 41600df

Browse files
authored
Merge branch 'main' into loop
2 parents 7e137b1 + 5f105bb commit 41600df

7 files changed

Lines changed: 38 additions & 6 deletions

File tree

.github/workflows/autofix.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ jobs:
3131
- name: 📦 Install dependencies
3232
run: pnpm install
3333

34-
- name: 📦 Install browsers
35-
run: pnpm playwright install
34+
- name: 🌐 Install browser
35+
run: pnpm playwright install chromium-headless-shell
3636

3737
- name: 🌐 Compare translations
3838
run: pnpm i18n:check

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
run: pnpm install
5757

5858
- name: 🌐 Install browser
59-
run: pnpm playwright install
59+
run: pnpm playwright install chromium-headless-shell
6060

6161
- name: 💪 Type check
6262
run: pnpm test:types

CONTRIBUTING.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,31 @@ Format: `type(scope): description`
522522
> [!NOTE]
523523
> The subject must start with a lowercase letter. Individual commit messages within your PR don't need to follow this format since they'll be squashed.
524524
525+
### PR descriptions
526+
527+
If your pull request directly addresses an open issue, use the following inside your PR description.
528+
529+
```text
530+
Resolves | Fixes | Closes: #xxx
531+
```
532+
533+
Replace `#xxx` with either a URL to the issue, or the number of the issue. For example:
534+
535+
```text
536+
Fixes #123
537+
```
538+
539+
or
540+
541+
```text
542+
Closes https://github.com/npmx-dev/npmx.dev/issues/123
543+
```
544+
545+
This provides the following benefits:
546+
547+
- it links the pull request to the issue (the merge icon will appear in the issue), so everybody can see there is an open PR
548+
- when the pull request is merged, the linked issue is automatically closed
549+
525550
## Pre-commit hooks
526551

527552
The project uses `lint-staged` with `simple-git-hooks` to automatically lint files on commit.
File renamed without changes.

app/composables/useAtproto.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
import type { UserSession } from '#shared/schemas/userSession'
22

33
export function useAtproto() {
4-
const { data: user, pending, clear } = useFetch<UserSession | null>('/api/auth/session')
4+
const {
5+
data: user,
6+
pending,
7+
clear,
8+
} = useFetch<UserSession | null>('/api/auth/session', {
9+
server: false,
10+
immediate: !import.meta.test,
11+
})
512

613
async function logout() {
714
await $fetch('/api/auth/session', {

playwright.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export default defineConfig<ConfigOptions>({
2828
},
2929
projects: [
3030
{
31-
name: 'chromium',
31+
name: 'chromium-headless-shell',
3232
use: { ...devices['Desktop Chrome'] },
3333
},
3434
],

test/unit/a11y-component-coverage.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const SKIPPED_COMPONENTS: Record<string, string> = {
3232
// Complex components requiring full app context or specific runtime conditions
3333
'Header/OrgsDropdown.vue': 'Requires connector context and API calls',
3434
'Header/PackagesDropdown.vue': 'Requires connector context and API calls',
35-
'Header/MobileMenu.vue': 'Requires Teleport and full navigation context',
35+
'Header/MobileMenu.client.vue': 'Requires Teleport and full navigation context',
3636
'Modal.client.vue':
3737
'Base modal component - tested via specific modals like ChartModal, ConnectorModal',
3838
'Package/SkillsModal.vue': 'Complex modal with tabs - requires modal context and state',

0 commit comments

Comments
 (0)