Skip to content

Commit 4715ebc

Browse files
committed
feat: apply review
1 parent ffa05b4 commit 4715ebc

4 files changed

Lines changed: 10 additions & 5 deletions

File tree

app/components/AppHeader.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,9 +219,9 @@ onKeyStroke(
219219
<AppMark class="w-6 h-auto" />
220220
</NuxtLink>
221221
<NuxtLink
222-
v-if="!isSearchExpanded && !isOnHomePage && prNumber"
222+
v-if="!isSearchExpanded && prNumber"
223223
:to="`https://github.com/npmx-dev/npmx.dev/pull/${prNumber}`"
224-
:aria-label="`Open GitHub pull request ${prNumber}`"
224+
:aria-label="$t('header.pr', { prNumber })"
225225
class="sm:hidden"
226226
>
227227
<span class="text-xs px-1.5 py-0.5 rounded badge-green font-sans font-medium ms-2">
@@ -248,7 +248,7 @@ onKeyStroke(
248248
<NuxtLink
249249
v-if="prNumber"
250250
:to="`https://github.com/npmx-dev/npmx.dev/pull/${prNumber}`"
251-
:aria-label="`Open GitHub pull request ${prNumber}`"
251+
:aria-label="$t('header.pr', { prNumber })"
252252
>
253253
<span class="text-xs px-1.5 py-0.5 rounded badge-green font-sans font-medium ms-2">
254254
PR #{{ prNumber }}

i18n/locales/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1033,7 +1033,8 @@
10331033
"error": "Failed to load organizations",
10341034
"empty": "No organizations found",
10351035
"view_all": "View all"
1036-
}
1036+
},
1037+
"pr": "Open GitHub pull request #{prNumber}"
10371038
},
10381039
"compare": {
10391040
"packages": {

i18n/locales/zh-CN.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1021,7 +1021,8 @@
10211021
"error": "加载组织失败",
10221022
"empty": "未找到组织",
10231023
"view_all": "查看全部"
1024-
}
1024+
},
1025+
"pr": "在 GitHub 上打开 PR #{prNumber}"
10251026
},
10261027
"compare": {
10271028
"packages": {

i18n/schema.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3105,6 +3105,9 @@
31053105
}
31063106
},
31073107
"additionalProperties": false
3108+
},
3109+
"pr": {
3110+
"type": "string"
31083111
}
31093112
},
31103113
"additionalProperties": false

0 commit comments

Comments
 (0)