Skip to content

Commit 474e3ea

Browse files
committed
namings
1 parent dd7d952 commit 474e3ea

4 files changed

Lines changed: 14 additions & 14 deletions

File tree

app/components/Package/TrendsChart.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ import type {
1818
YearlyDataPoint,
1919
} from '~/types/chart'
2020
import { DATE_INPUT_MAX } from '~/utils/input'
21-
import { applyDownloadFilter } from '~/utils/chart-data-correction'
22-
import { applyBlocklistFilter } from '~/utils/download-anomalies'
21+
import { applyDataCorrection } from '~/utils/chart-data-correction'
22+
import { applyBlocklistCorrection } from '~/utils/download-anomalies'
2323
2424
const props = withDefaults(
2525
defineProps<{
@@ -946,9 +946,9 @@ const effectiveDataSingle = computed<EvolutionData>(() => {
946946
if (isDownloadsMetric.value && data.length) {
947947
const pkg = effectivePackageNames.value[0] ?? props.packageName ?? ''
948948
if (settings.value.chartFilter.anomaliesFixed) {
949-
data = applyBlocklistFilter(data, pkg, displayedGranularity.value)
949+
data = applyBlocklistCorrection(data, pkg, displayedGranularity.value)
950950
}
951-
return applyDownloadFilter(
951+
return applyDataCorrection(
952952
data as Array<{ value: number }>,
953953
settings.value.chartFilter,
954954
) as EvolutionData
@@ -990,9 +990,9 @@ const chartData = computed<{
990990
let data = state.evolutionsByPackage[pkg] ?? []
991991
if (isDownloadsMetric.value && data.length) {
992992
if (settings.value.chartFilter.anomaliesFixed) {
993-
data = applyBlocklistFilter(data, pkg, granularity)
993+
data = applyBlocklistCorrection(data, pkg, granularity)
994994
}
995-
data = applyDownloadFilter(
995+
data = applyDataCorrection(
996996
data as Array<{ value: number }>,
997997
settings.value.chartFilter,
998998
) as EvolutionData

app/components/Package/WeeklyDownloadStats.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
import { VueUiSparkline } from 'vue-data-ui/vue-ui-sparkline'
33
import { useCssVariables } from '~/composables/useColors'
44
import type { WeeklyDataPoint } from '~/types/chart'
5-
import { applyDownloadFilter } from '~/utils/chart-data-correction'
5+
import { applyDataCorrection } from '~/utils/chart-data-correction'
66
import { OKLCH_NEUTRAL_FALLBACK, lightenOklch } from '~/utils/colors'
7-
import { applyBlocklistFilter } from '~/utils/download-anomalies'
7+
import { applyBlocklistCorrection } from '~/utils/download-anomalies'
88
import type { RepoRef } from '#shared/utils/git-providers'
99
import type { VueUiSparklineConfig, VueUiSparklineDatasetItem } from 'vue-data-ui'
1010
@@ -179,18 +179,18 @@ watch(
179179
() => loadWeeklyDownloads(),
180180
)
181181
182-
const filteredDownloads = computed<WeeklyDataPoint[]>(() => {
182+
const correctedDownloads = computed<WeeklyDataPoint[]>(() => {
183183
let data = weeklyDownloads.value as WeeklyDataPoint[]
184184
if (!data.length) return data
185185
if (settings.value.chartFilter.anomaliesFixed) {
186-
data = applyBlocklistFilter(data, props.packageName, 'weekly') as WeeklyDataPoint[]
186+
data = applyBlocklistCorrection(data, props.packageName, 'weekly') as WeeklyDataPoint[]
187187
}
188-
data = applyDownloadFilter(data, settings.value.chartFilter) as WeeklyDataPoint[]
188+
data = applyDataCorrection(data, settings.value.chartFilter) as WeeklyDataPoint[]
189189
return data
190190
})
191191
192192
const dataset = computed<VueUiSparklineDatasetItem[]>(() =>
193-
filteredDownloads.value.map(d => ({
193+
correctedDownloads.value.map(d => ({
194194
value: d?.value ?? 0,
195195
period: $t('package.trends.date_range', {
196196
start: d.weekStart ?? '-',

app/utils/chart-data-correction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export interface ChartFilterSettings {
8585
/**
8686
* Applies moving average then smoothing in sequence.
8787
*/
88-
export function applyDownloadFilter<T extends { value: number }>(
88+
export function applyDataCorrection<T extends { value: number }>(
8989
data: T[],
9090
settings: ChartFilterSettings,
9191
): T[] {

app/utils/download-anomalies.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ function scaleWeeklyValue(weeklyValue: number, granularity: ChartTimeGranularity
6565
}
6666
}
6767

68-
export function applyBlocklistFilter(
68+
export function applyBlocklistCorrection(
6969
data: EvolutionData,
7070
packageName: string,
7171
granularity: ChartTimeGranularity,

0 commit comments

Comments
 (0)