Skip to content

Commit 485cc9c

Browse files
authored
fix: remove disabledReason from sort dropdowns to avoid UI issues when not in English (#519)
1 parent f8494ef commit 485cc9c

2 files changed

Lines changed: 1 addition & 19 deletions

File tree

app/components/PackageListToolbar.vue

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ const availableSortKeys = computed(() => {
6262
return SORT_KEYS.filter(k => !k.searchOnly || k.key === 'relevance').map(k =>
6363
Object.assign({}, k, {
6464
disabled: k.key !== 'relevance',
65-
disabledReason: k.key !== 'relevance' ? 'Coming soon' : undefined,
6665
}),
6766
)
6867
}
@@ -162,8 +161,7 @@ function getSortKeyLabelKey(key: SortKey): string {
162161
:value="keyConfig.key"
163162
:disabled="keyConfig.disabled"
164163
>
165-
{{ $t(getSortKeyLabelKey(keyConfig.key))
166-
}}{{ keyConfig.disabled ? ` (${$t('filters.columns.coming_soon')})` : '' }}
164+
{{ $t(getSortKeyLabelKey(keyConfig.key)) }}
167165
</option>
168166
</select>
169167
<div

shared/types/preferences.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ export interface ColumnConfig {
2929
width?: string
3030
/** Whether the column is disabled (not yet available) */
3131
disabled?: boolean
32-
/** Reason for being disabled, shown in UI */
33-
disabledReason?: string
3432
}
3533

3634
// Default column configuration
@@ -55,7 +53,6 @@ export const DEFAULT_COLUMNS: ColumnConfig[] = [
5553
sortable: true,
5654
width: '100px',
5755
disabled: true,
58-
disabledReason: 'Coming soon',
5956
},
6057
{
6158
id: 'popularityScore',
@@ -64,7 +61,6 @@ export const DEFAULT_COLUMNS: ColumnConfig[] = [
6461
sortable: true,
6562
width: '100px',
6663
disabled: true,
67-
disabledReason: 'Coming soon',
6864
},
6965
{
7066
id: 'maintenanceScore',
@@ -73,7 +69,6 @@ export const DEFAULT_COLUMNS: ColumnConfig[] = [
7369
sortable: true,
7470
width: '100px',
7571
disabled: true,
76-
disabledReason: 'Coming soon',
7772
},
7873
{
7974
id: 'combinedScore',
@@ -82,7 +77,6 @@ export const DEFAULT_COLUMNS: ColumnConfig[] = [
8277
sortable: true,
8378
width: '100px',
8479
disabled: true,
85-
disabledReason: 'Coming soon',
8680
},
8781
{
8882
id: 'security',
@@ -91,7 +85,6 @@ export const DEFAULT_COLUMNS: ColumnConfig[] = [
9185
sortable: false,
9286
width: '80px',
9387
disabled: true,
94-
disabledReason: 'Coming soon',
9588
},
9689
]
9790

@@ -143,8 +136,6 @@ export interface SortKeyConfig {
143136
defaultDirection: SortDirection
144137
/** Whether the sort option is disabled (not yet available) */
145138
disabled?: boolean
146-
/** Reason for being disabled, shown in UI */
147-
disabledReason?: string
148139
/** Only show this sort option in search context */
149140
searchOnly?: boolean
150141
}
@@ -157,21 +148,18 @@ export const SORT_KEYS: SortKeyConfig[] = [
157148
label: 'Downloads/day',
158149
defaultDirection: 'desc',
159150
disabled: true,
160-
disabledReason: 'Coming soon',
161151
},
162152
{
163153
key: 'downloads-month',
164154
label: 'Downloads/mo',
165155
defaultDirection: 'desc',
166156
disabled: true,
167-
disabledReason: 'Coming soon',
168157
},
169158
{
170159
key: 'downloads-year',
171160
label: 'Downloads/yr',
172161
defaultDirection: 'desc',
173162
disabled: true,
174-
disabledReason: 'Coming soon',
175163
},
176164
{ key: 'updated', label: 'Updated', defaultDirection: 'desc' },
177165
{ key: 'name', label: 'Name', defaultDirection: 'asc' },
@@ -180,28 +168,24 @@ export const SORT_KEYS: SortKeyConfig[] = [
180168
label: 'Quality',
181169
defaultDirection: 'desc',
182170
disabled: true,
183-
disabledReason: 'Coming soon',
184171
},
185172
{
186173
key: 'popularity',
187174
label: 'Popularity',
188175
defaultDirection: 'desc',
189176
disabled: true,
190-
disabledReason: 'Coming soon',
191177
},
192178
{
193179
key: 'maintenance',
194180
label: 'Maintenance',
195181
defaultDirection: 'desc',
196182
disabled: true,
197-
disabledReason: 'Coming soon',
198183
},
199184
{
200185
key: 'score',
201186
label: 'Score',
202187
defaultDirection: 'desc',
203188
disabled: true,
204-
disabledReason: 'Coming soon',
205189
},
206190
]
207191

0 commit comments

Comments
 (0)