Skip to content

Commit 48fa041

Browse files
test: avoid redundant html validation (#1083)
Co-authored-by: Daniel Roe <daniel@roe.dev>
1 parent 352ec4f commit 48fa041

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,9 @@ jobs:
150150
run: pnpm install
151151

152152
- name: 🏗️ Build project
153-
run: pnpm build:playwright
153+
run: pnpm build:test
154+
env:
155+
VALIDATE_HTML: true
154156

155157
- name: 🖥️ Test project (browser)
156158
run: pnpm test:browser:prebuilt
@@ -178,7 +180,7 @@ jobs:
178180
run: pnpm install
179181

180182
- name: 🏗️ Build project
181-
run: NODE_ENV=test pnpm build
183+
run: pnpm build:test
182184

183185
- name: ♿ Accessibility audit (Lighthouse - ${{ matrix.mode }} mode)
184186
run: ./scripts/lighthouse-a11y.sh

nuxt.config.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import process from 'node:process'
22
import { currentLocales } from './config/i18n'
3+
import { isCI, provider } from 'std-env'
34

45
export default defineNuxtConfig({
56
modules: [
@@ -195,6 +196,7 @@ export default defineNuxtConfig({
195196
},
196197

197198
htmlValidator: {
199+
enabled: !isCI || (provider !== 'vercel' && !!process.env.VALIDATE_HTML),
198200
failOnError: true,
199201
},
200202

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"scripts": {
1313
"build": "nuxt build",
1414
"build:lunaria": "node ./lunaria/lunaria.ts",
15-
"build:playwright": "NODE_ENV=test pnpm build",
15+
"build:test": "NODE_ENV=test pnpm build",
1616
"dev": "nuxt dev",
1717
"dev:docs": "pnpm run --filter npmx-docs dev --port=3001",
1818
"i18n:check": "node scripts/compare-translations.ts",
@@ -30,10 +30,10 @@
3030
"generate:fixtures": "node scripts/generate-fixtures.ts",
3131
"generate:lexicons": "lex build --lexicons lexicons --out shared/types/lexicons --clear",
3232
"test": "vite test",
33-
"test:browser": "pnpm build:playwright && pnpm test:browser:prebuilt",
33+
"test:browser": "pnpm build:test && pnpm test:browser:prebuilt",
3434
"test:browser:prebuilt": "playwright test",
35-
"test:browser:ui": "pnpm build:playwright && pnpm test:browser:prebuilt --ui",
36-
"test:browser:update": "pnpm build:playwright && pnpm test:browser:prebuilt --update-snapshots",
35+
"test:browser:ui": "pnpm build:test && pnpm test:browser:prebuilt --ui",
36+
"test:browser:update": "pnpm build:test && pnpm test:browser:prebuilt --update-snapshots",
3737
"test:nuxt": "vite test --project nuxt",
3838
"test:types": "pnpm generate:lexicons && nuxt prepare && vue-tsc -b --noEmit && pnpm --filter npmx-connector test:types",
3939
"test:unit": "vite test --project unit",

0 commit comments

Comments
 (0)