Skip to content

Commit 509914e

Browse files
committed
fix: follow the rabbit
1 parent 1407af3 commit 509914e

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

app/components/Package/TrendsChart.vue

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1640,11 +1640,11 @@ const isSparklineLayout = shallowRef(false)
16401640
:aria-label="'Chart layout toggle'"
16411641
>
16421642
<button
1643-
id="classic-line-chart-layout"
1643+
id="combined-chart-layout-tab"
16441644
type="button"
16451645
role="tab"
16461646
:aria-selected="isSparklineLayout ? 'false' : 'true'"
1647-
aria-controls="TODO"
1647+
aria-controls="combined-chart-layout-panel"
16481648
:tabindex="isSparklineLayout ? 0 : -1"
16491649
class="flex items-center justify-center gap-x-2 rounded px-3 py-2 font-mono text-sm border border-solid transition-colors duration-150 focus-visible:outline-accent/70"
16501650
:class="
@@ -1659,12 +1659,12 @@ const isSparklineLayout = shallowRef(false)
16591659
</button>
16601660

16611661
<button
1662-
id="comparison-tab-charts"
1662+
id="split-chart-layout-tab"
16631663
type="button"
16641664
role="tab"
16651665
:aria-selected="isSparklineLayout ? 'true' : 'false'"
1666-
aria-controls="comparison-panel-charts"
1667-
:tabindex="isSparklineLayout ? -1 : 0"
1666+
aria-controls="split-chart-layout-panel"
1667+
:tabindex="!isSparklineLayout ? 0 : -1"
16681668
class="flex items-center justify-center gap-x-2 rounded px-3 py-2 font-mono text-sm border border-solid transition-colors duration-150 focus-visible:outline-accent/70"
16691669
:class="
16701670
isSparklineLayout
@@ -1923,15 +1923,17 @@ const isSparklineLayout = shallowRef(false)
19231923
"
19241924
>
19251925
<ClientOnly v-if="chartData.dataset">
1926-
<div v-if="isSparklineLayout">
1926+
<div v-if="isSparklineLayout" id="split-chart-layout-panel" role="tabpanel"
1927+
aria-labelledby="split-chart-layout-tab">
19271928
<ChartSplitSparkline
19281929
:dataset="normalisedDataset"
19291930
:dates="chartData.dates"
19301931
:datetimeFormatterOptions
19311932
/>
19321933
</div>
19331934

1934-
<div :data-pending="pending" :data-minimap-visible="maxDatapoints > 6" v-else>
1935+
<div :data-pending="pending" :data-minimap-visible="maxDatapoints > 6" v-else id="combined-chart-layout-panel" role="tabpanel"
1936+
aria-labelledby="combined-chart-layout-tab">
19351937
<VueUiXy
19361938
:dataset="normalisedDataset"
19371939
:config="chartConfig"

0 commit comments

Comments
 (0)