test: add property based tests via fast-check

Author: dubzzz

package.json

@@ -104,6 +104,7 @@
     "@vitest/coverage-v8": "4.0.18",
     "@vue/test-utils": "2.4.6",
     "axe-core": "4.11.1",
+    "fast-check": "4.5.3",
     "fast-npm-meta": "1.0.0",
     "knip": "5.82.1",
     "lint-staged": "16.2.7",

pnpm-lock.yaml

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest'
+import * as fc from 'fast-check'
 import {
   escapeHtml,
   parseJsDocLinks,
@@ -40,6 +41,15 @@ describe('stripAnsi', () => {
     const input = `object is ReactElement${ESC}[0m${ESC}[38;5;12m<${ESC}[0mP${ESC}[38;5;12m>${ESC}[0m`
     expect(stripAnsi(input)).toBe('object is ReactElement<P>')
   })
+
+  it('should strip everything in one pass', () => {
+    fc.assert(
+      fc.property(fc.string(), input => {
+        const stripped = stripAnsi(input)
+        expect(stripAnsi(stripped)).toBe(stripped)
+      }),
+    )
+  })
 })
 
 describe('escapeHtml', () => {
@@ -124,6 +134,65 @@ describe('parseJsDocLinks', () => {
     const result = parseJsDocLinks('{@link http://example.com}', emptyLookup)
     expect(result).toContain('href="http://example.com"')
   })
+
+  it('should convert external URLs using {@link url} to links', () => {
+    fc.assert(
+      fc.property(fc.webUrl(), url => {
+        const result = parseJsDocLinks(`{@link ${url}}`, emptyLookup)
+        expect(result).toContain(`href="${url.replaceAll('"', '\\"')}"`)
+        expect(result).toContain('target="_blank"')
+        expect(result).toContain('rel="noreferrer"')
+        expect(result).toContain(escapeHtml(url))
+      }),
+    )
+  })
+
+  it('should convert external URLs using {@link url text} to links', () => {
+    fc.assert(
+      fc.property(fc.webUrl(), fc.stringMatching(/^[^}\s][^}]+[^}\s]$/), (url, text) => {
+        const result = parseJsDocLinks(`{@link ${url} ${text}}`, emptyLookup)
+        expect(result).toContain(`href="${url.replaceAll('"', '\\"')}"`)
+        expect(result).toContain('target="_blank"')
+        expect(result).toContain('rel="noreferrer"')
+        expect(result).toContain(escapeHtml(text))
+      }),
+    )
+  })
+
+  it('should be able to treat correctly several external URLs at the middle of a text', () => {
+    const surrounding = fc.stringMatching(/^[^{]*$/)
+    const link = fc.record({
+      url: fc.webUrl(),
+      label: fc.option(fc.stringMatching(/^[^}\s][^}]+[^}\s]$/)),
+      before: surrounding,
+      after: surrounding,
+    })
+    fc.assert(
+      fc.property(fc.array(link, { minLength: 1 }), content => {
+        let docString = ''
+        const expectedUrls = []
+        for (const chunk of content) {
+          if (chunk.before.length !== 0 || docString.length !== 0) {
+            docString += `${chunk.before} `
+          }
+          if (chunk.label === null) {
+            docString += `{@link ${chunk.url}}`
+            expectedUrls.push(chunk.url)
+          } else {
+            docString += `{@link ${chunk.url} ${chunk.label}}`
+            expectedUrls.push(chunk.url)
+          }
+          if (chunk.after.length !== 0) {
+            docString += ` ${chunk.after}`
+          }
+        }
+        const result = parseJsDocLinks(docString, emptyLookup)
+        for (const url of expectedUrls) {
+          expect(result).toContain(`href="${url.replaceAll('"', '\\"')}"`)
+        }
+      }),
+    )
+  })
 })
 
 describe('renderMarkdown', () => {

test/unit/server/utils/docs/text.spec.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it, vi } from 'vitest'
+import * as fc from 'fast-check'
 import { mapWithConcurrency } from '../../../../shared/utils/async'
 
 describe('mapWithConcurrency', () => {
@@ -92,4 +93,49 @@ describe('mapWithConcurrency', () => {
     // Should only have 3 concurrent since we only have 3 items
     expect(maxConcurrent).toBe(3)
   })
+
+  it('waits for all tasks to succeed and return them in order whatever their count and the concurrency', async () => {
+    await fc.assert(
+      fc.asyncProperty(
+        fc.array(fc.anything()),
+        fc.integer({ min: 1 }),
+        fc.scheduler(),
+        async (items, concurrency, s) => {
+          const fn = s.scheduleFunction(async item => item)
+          const results = await s.waitFor(mapWithConcurrency(items, fn, concurrency))
+          expect(results).toEqual(items)
+        },
+      ),
+    )
+  })
+
+  it('not run more than concurrency tasks in parallel', async () => {
+    await fc.assert(
+      fc.asyncProperty(
+        fc.array(fc.anything()), // TODO, support failing tasks too
+        fc.integer({ min: 1 }),
+        fc.scheduler(),
+        async (items, concurrency, s) => {
+          let tooManyRunningTasksEncountered = false
+          let currentlyRunning = 0
+          const fn = async (item: (typeof items)[number]) => {
+            currentlyRunning++
+            if (currentlyRunning > concurrency) {
+              tooManyRunningTasksEncountered = true
+            }
+            const task = s.schedule(Promise.resolve(item))
+            task.then(
+              // not a finally as we want to handle failing tasks too in the future
+              () => currentlyRunning--,
+              () => currentlyRunning--,
+            )
+            return task
+          }
+          await s.waitFor(mapWithConcurrency(items, fn, concurrency))
+          expect(tooManyRunningTasksEncountered).toBe(false)
+        },
+      ),
+      { endOnFailure: true },
+    )
+  })
 })