Skip to content

Commit 56ee7b5

Browse files
authored
fix: filter ux to keep toggle on right (#1677)
1 parent 5bcfb8e commit 56ee7b5

File tree

2 files changed

+6
-22
lines changed

2 files changed

+6
-22
lines changed

app/components/ColumnPicker.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ function handleReset() {
8585
v-if="isOpen"
8686
ref="menuRef"
8787
:id="menuId"
88-
class="absolute top-full inset-ie-0 sm:inset-is-auto sm:inset-ie-0 mt-2 w-60 bg-bg-subtle border border-border rounded-lg shadow-lg z-20"
88+
class="absolute top-full inset-is-auto sm:inset-ie-0 mt-2 w-60 bg-bg-subtle border border-border rounded-lg shadow-lg z-20"
8989
role="group"
9090
:aria-label="$t('filters.columns.show')"
9191
>

app/components/Package/ListToolbar.vue

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -157,11 +157,9 @@ function getSortKeyLabelKey(key: SortKey): string {
157157

158158
<div class="flex-1" />
159159

160-
<div
161-
class="flex flex-wrap items-center gap-3 sm:justify-end justify-between w-full sm:w-auto"
162-
>
160+
<div class="flex flex-col sm:flex-row items-start sm:items-center gap-3">
163161
<!-- Sort controls -->
164-
<div class="flex items-center gap-1 shrink-0 order-1 sm:order-1">
162+
<div class="flex items-center gap-1 shrink-0">
165163
<!-- Sort key dropdown -->
166164
<SelectField
167165
:label="$t('filters.sort.label')"
@@ -203,29 +201,15 @@ function getSortKeyLabelKey(key: SortKey): string {
203201
</div>
204202

205203
<!-- View mode toggle - mobile (left side, row 2) -->
206-
<div class="flex sm:hidden items-center gap-1 order-2">
207-
<ViewModeToggle v-model="viewMode" />
208-
</div>
209-
210-
<!-- Column picker - mobile (right side, row 2) -->
211-
<ColumnPicker
212-
v-if="viewMode === 'table'"
213-
class="flex sm:hidden order-3"
214-
:columns="columns"
215-
@toggle="emit('toggleColumn', $event)"
216-
@reset="emit('resetColumns')"
217-
/>
218-
219-
<!-- View mode toggle + Column picker - desktop (right side, row 1) -->
220-
<div class="hidden sm:flex items-center gap-1 order-2">
221-
<ViewModeToggle v-model="viewMode" />
222-
204+
<div class="flex flex-row-reverse sm:flex-row items-center gap-1">
223205
<ColumnPicker
224206
v-if="viewMode === 'table'"
225207
:columns="columns"
226208
@toggle="emit('toggleColumn', $event)"
227209
@reset="emit('resetColumns')"
228210
/>
211+
212+
<ViewModeToggle v-model="viewMode" />
229213
</div>
230214
</div>
231215
</div>

0 commit comments

Comments
 (0)