Skip to content

Commit 59403e2

Browse files
committed
chore: use no-new-tab-icon instead no-external-icon (LinkBase updated)
1 parent 54e003c commit 59403e2

File tree

1 file changed

+5
-26
lines changed

1 file changed

+5
-26
lines changed

app/pages/about.vue

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -153,33 +153,15 @@ function onDocumentKeydown(e: KeyboardEvent) {
153153
}
154154
}
155155
156-
function addListeners() {
156+
onMounted(() => {
157157
document.addEventListener('pointerdown', onDocumentPointerDown)
158158
document.addEventListener('keydown', onDocumentKeydown)
159-
}
160-
161-
function removeListeners() {
162-
document.removeEventListener('pointerdown', onDocumentPointerDown)
163-
document.removeEventListener('keydown', onDocumentKeydown)
164-
}
165-
166-
onMounted(() => {
167-
addListeners()
168159
})
169160
170161
onBeforeUnmount(() => {
171162
cancelClose()
172-
removeListeners()
173-
})
174-
175-
onActivated(() => {
176-
addListeners()
177-
})
178-
179-
onDeactivated(() => {
180-
cancelClose()
181-
activeContributor.value = null
182-
removeListeners()
163+
document.removeEventListener('pointerdown', onDocumentPointerDown)
164+
document.removeEventListener('keydown', onDocumentKeydown)
183165
})
184166
</script>
185167

@@ -316,10 +298,7 @@ onDeactivated(() => {
316298
{{ $t('about.contributors.description') }}
317299
</p>
318300
<section aria-labelledby="contributors-heading">
319-
<h3
320-
id="contributors-heading"
321-
class="text-sm text-fg uppercase tracking-wider mb-4"
322-
>
301+
<h3 id="contributors-heading" class="text-sm text-fg uppercase tracking-wider mb-4">
323302
{{
324303
$t(
325304
'about.contributors.title',
@@ -356,7 +335,7 @@ onDeactivated(() => {
356335
v-if="!isExpandable(contributor)"
357336
:to="contributor.html_url"
358337
no-underline
359-
no-external-icon
338+
no-new-tab-icon
360339
:aria-label="getAriaLabel(contributor)"
361340
class="group relative block h-12 w-12 rounded-lg transition-all outline-none p-0 bg-transparent"
362341
>

0 commit comments

Comments
 (0)