Skip to content

Commit 62c88fc

Browse files
committed
refactor: change default element for button group
1 parent 2fce723 commit 62c88fc

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

app/components/AppHeader.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ onKeyStroke(
150150
</div>
151151

152152
<!-- End: Desktop nav items + Mobile menu button -->
153-
<ButtonGroup as="div" class="hidden sm:flex flex-shrink-0">
153+
<ButtonGroup class="hidden sm:flex flex-shrink-0">
154154
<!-- Desktop: Compare link -->
155155
<LinkBase variant="button-secondary" :to="{ name: 'compare' }" keyshortcut="c">
156156
{{ $t('nav.compare') }}

app/components/Button/Group.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const props = defineProps<{
66

77
<template>
88
<component
9-
:is="props.as || 'nav'"
9+
:is="props.as || 'div'"
1010
class="flex items-center shrink-0 ms-auto [&>*:not(:first-child)]:rounded-s-none [&>*:not(:first-child)]:border-s-0 [&>*:not(:last-child)]:rounded-e-none"
1111
>
1212
<slot />

app/pages/package/[[org]]/[name].vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -649,6 +649,7 @@ onKeyStroke(
649649
<!-- Internal navigation: Docs + Code + Compare (hidden on mobile, shown in external links instead) -->
650650
<ButtonGroup
651651
v-if="resolvedVersion"
652+
as="div"
652653
:aria-label="$t('package.navigation')"
653654
class="hidden sm:flex"
654655
>

0 commit comments

Comments
 (0)