test: fix assertions

Author: serhalp

test/nuxt/components/compare/FacetSelector.spec.ts

@@ -129,23 +129,23 @@ describe('FacetSelector', () => {
 
       // totalDependencies is marked as comingSoon
       const buttons = component.findAll('button')
-      const comingSoonButton = buttons.find(b => b.text().includes('Total Dependencies'))
+      const comingSoonButton = buttons.find(b => b.text().includes('# Total Deps'))
 
       expect(comingSoonButton?.attributes('disabled')).toBeDefined()
     })
 
     it('shows coming soon text for comingSoon facets', async () => {
       const component = await mountSuspended(FacetSelector)
 
-      expect(component.text()).toContain('coming soon')
+      expect(component.text().toLowerCase()).toContain('coming soon')
     })
 
     it('does not show checkmark/add icon for comingSoon facets', async () => {
       const component = await mountSuspended(FacetSelector)
 
       // Find the comingSoon button
       const buttons = component.findAll('button')
-      const comingSoonButton = buttons.find(b => b.text().includes('Total Dependencies'))
+      const comingSoonButton = buttons.find(b => b.text().includes('# Total Deps'))
 
       // Should not have checkmark or add icon
       expect(comingSoonButton?.find('.i-carbon\\:checkmark').exists()).toBe(false)
@@ -156,7 +156,7 @@ describe('FacetSelector', () => {
       const component = await mountSuspended(FacetSelector)
 
       const buttons = component.findAll('button')
-      const comingSoonButton = buttons.find(b => b.text().includes('Total Dependencies'))
+      const comingSoonButton = buttons.find(b => b.text().includes('# Total Deps'))
       await comingSoonButton?.trigger('click')
 
       // toggleFacet should not have been called with totalDependencies
@@ -176,6 +176,10 @@ describe('FacetSelector', () => {
     })
 
     it('calls deselectCategory when none button is clicked', async () => {
+      // Select a performance facet so 'none' button is enabled
+      mockSelectedFacets.value = ['packageSize']
+      mockIsFacetSelected.mockImplementation((f: string) => f === 'packageSize')
+
       const component = await mountSuspended(FacetSelector)
 
       // Find the first 'none' button (for performance category)

test/nuxt/components/compare/MetricRow.spec.ts

@@ -33,14 +33,14 @@ describe('MetricRow', () => {
           description: 'Number of downloads per week',
         },
       })
-      expect(component.find('.i-carbon-information').exists()).toBe(true)
+      expect(component.find('.i-carbon\\:information').exists()).toBe(true)
     })
 
     it('does not render description icon when not provided', async () => {
       const component = await mountSuspended(MetricRow, {
         props: baseProps,
       })
-      expect(component.find('.i-carbon-information').exists()).toBe(false)
+      expect(component.find('.i-carbon\\:information').exists()).toBe(false)
     })
   })
 
@@ -79,7 +79,7 @@ describe('MetricRow', () => {
           loading: true,
         },
       })
-      expect(component.find('.i-carbon-circle-dash').exists()).toBe(true)
+      expect(component.find('.i-carbon\\:circle-dash').exists()).toBe(true)
     })
   })
 
@@ -155,20 +155,6 @@ describe('MetricRow', () => {
       expect(component.findAll('.bg-fg\\/5').length).toBe(0)
     })
 
-    it('auto-detects numeric values for bar display', async () => {
-      const component = await mountSuspended(MetricRow, {
-        props: {
-          ...baseProps,
-          values: [
-            { raw: 1000, display: '1K', status: 'neutral' },
-            { raw: 2000, display: '2K', status: 'neutral' },
-          ],
-        },
-      })
-      // Should show bars by default for numeric values
-      expect(component.findAll('.bg-fg\\/5').length).toBeGreaterThan(0)
-    })
-
     it('does not show bar for non-numeric values', async () => {
       const component = await mountSuspended(MetricRow, {
         props: {
@@ -195,7 +181,7 @@ describe('MetricRow', () => {
           diffs: [null, { direction: 'increase', display: '+100%', favorable: true }],
         },
       })
-      expect(component.find('.i-carbon-arrow-up').exists()).toBe(true)
+      expect(component.find('.i-carbon\\:arrow-up').exists()).toBe(true)
       expect(component.text()).toContain('+100%')
     })
 
@@ -210,7 +196,7 @@ describe('MetricRow', () => {
           diffs: [null, { direction: 'decrease', display: '-50%', favorable: false }],
         },
       })
-      expect(component.find('.i-carbon-arrow-down').exists()).toBe(true)
+      expect(component.find('.i-carbon\\:arrow-down').exists()).toBe(true)
     })
 
     it('applies favorable diff styling (green)', async () => {
@@ -254,8 +240,8 @@ describe('MetricRow', () => {
           diffs: [null, { direction: 'same', display: '0%', favorable: undefined }],
         },
       })
-      expect(component.find('.i-carbon-arrow-up').exists()).toBe(false)
-      expect(component.find('.i-carbon-arrow-down').exists()).toBe(false)
+      expect(component.find('.i-carbon\\:arrow-up').exists()).toBe(false)
+      expect(component.find('.i-carbon\\:arrow-down').exists()).toBe(false)
     })
   })