Skip to content

Commit 6378bee

Browse files
hacknugdanielroe
andauthored
fix: use tooltips in table columns dropdown to avoid spanning multiple lines (#370)
Co-authored-by: Daniel Roe <daniel@roe.dev>
1 parent 3ac0f83 commit 6378bee

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

app/components/ColumnPicker.vue

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ function handleReset() {
9393
v-if="isOpen"
9494
ref="menuRef"
9595
:id="menuId"
96-
class="absolute right-0 mt-2 w-56 bg-bg-subtle border border-border rounded-lg shadow-lg z-20"
96+
class="absolute right-0 mt-2 w-60 bg-bg-subtle border border-border rounded-lg shadow-lg z-20"
9797
role="group"
9898
:aria-label="$t('filters.columns.show')"
9999
>
@@ -109,7 +109,7 @@ function handleReset() {
109109
<label
110110
v-for="column in toggleableColumns"
111111
:key="column.id"
112-
class="flex items-center px-3 py-2 transition-colors duration-200"
112+
class="flex gap-2 items-center px-3 py-2 transition-colors duration-200"
113113
:class="
114114
column.disabled
115115
? 'opacity-50 cursor-not-allowed'
@@ -124,16 +124,20 @@ function handleReset() {
124124
class="w-4 h-4 accent-fg bg-bg-muted border-border rounded disabled:opacity-50"
125125
@change="!column.disabled && emit('toggle', column.id)"
126126
/>
127-
<span class="ml-2 text-sm text-fg-muted font-mono flex-1">
127+
<span class="text-sm text-fg-muted font-mono flex-1">
128128
{{ getColumnLabel(column.id) }}
129129
</span>
130-
<span
130+
<AppTooltip
131131
v-if="column.disabled"
132132
:id="`${column.id}-disabled-reason`"
133-
class="text-xs text-fg-subtle italic"
133+
class="text-fg-subtle"
134+
:text="$t('filters.columns.coming_soon')"
135+
position="left"
134136
>
135-
{{ $t('filters.columns.coming_soon') }}
136-
</span>
137+
<span class="size-4 flex justify-center items-center text-xs border rounded-full"
138+
>i</span
139+
>
140+
</AppTooltip>
137141
</label>
138142
</div>
139143

0 commit comments

Comments
 (0)