Skip to content

Commit 65d1a87

Browse files
committed
Use resolveDocUrl
1 parent 4041dbd commit 65d1a87

File tree

4 files changed

+5
-26
lines changed

4 files changed

+5
-26
lines changed

app/components/Compare/ReplacementSuggestion.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<script setup lang="ts">
22
import type { ModuleReplacement } from 'module-replacements'
3-
import { resolveReplacementUrl } from '~/utils/resolve-replacement-url'
3+
import { resolveDocUrl } from 'module-replacements'
44
55
const props = defineProps<{
66
packageName: string
@@ -15,7 +15,7 @@ const emit = defineEmits<{
1515
addNoDep: []
1616
}>()
1717
18-
const docUrl = computed(() => resolveReplacementUrl(props.replacement.url))
18+
const docUrl = computed(() => resolveDocUrl(props.replacement.url))
1919
2020
const nodeVersion = computed(() => {
2121
const nodeEngine = props.replacement.engines?.find(e => e.engine === 'nodejs')

app/components/Package/Replacement.vue

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
<script setup lang="ts">
22
import type { ModuleReplacement, ModuleReplacementMapping } from 'module-replacements'
3-
import { resolveReplacementUrl } from '~/utils/resolve-replacement-url'
3+
import { resolveDocUrl } from 'module-replacements'
44
55
const props = defineProps<{
66
mapping: ModuleReplacementMapping
77
replacement: ModuleReplacement
88
}>()
99
10-
const externalUrl = computed(() =>
11-
resolveReplacementUrl(props.mapping.url ?? props.replacement.url),
12-
)
10+
const externalUrl = computed(() => resolveDocUrl(props.mapping.url ?? props.replacement.url))
1311
1412
const nodeVersion = computed(() => {
1513
const nodeEngine = props.replacement.engines?.find(e => e.engine === 'nodejs')

app/utils/resolve-replacement-url.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

test/e2e/package-replacements.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@ test.describe('Package Replacement Suggestions', () => {
1010
// Wait for the package page to load
1111
await expect(page.locator('h1')).toContainText('strip-ansi', { timeout: 15_000 })
1212

13-
// The replacement component renders a "Learn more" anchor driven by resolveReplacementUrl.
13+
// The replacement component renders a "Learn more" anchor.
1414
// For strip-ansi the url.type is 'e18e', so the href resolves to:
1515
// https://e18e.dev/docs/replacements/strip-ansi
16-
//
17-
// useLazyFetch is used, so the suggestion arrives after hydration — use a generous timeout.
1816
const replacementLink = page.locator('a[href="https://e18e.dev/docs/replacements/strip-ansi"]')
1917
await expect(replacementLink).toBeVisible({ timeout: 15_000 })
2018
})

0 commit comments

Comments
 (0)