Skip to content

Commit 6a17ce3

Browse files
committed
fix: avoid slash as separator for numbers
A slash between numbers implies some sort of fraction or ratio. It isn't intuitive what it means between two dependency counts and between sizes.
1 parent 9342f6c commit 6a17ce3

1 file changed

Lines changed: 23 additions & 21 deletions

File tree

app/pages/package/[[org]]/[name].vue

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -583,10 +583,8 @@ const showSkeleton = shallowRef(false)
583583
<!-- Direct deps (muted) -->
584584
<span class="text-fg-muted">{{ numberFormatter.format(dependencyCount) }}</span>
585585

586-
<!-- Separator and total transitive deps -->
586+
<!-- Total transitive deps in parens -->
587587
<template v-if="dependencyCount > 0 && dependencyCount !== totalDepsCount">
588-
<span class="text-fg-subtle">/</span>
589-
590588
<ClientOnly>
591589
<span
592590
v-if="
@@ -595,14 +593,16 @@ const showSkeleton = shallowRef(false)
595593
"
596594
class="inline-flex items-center gap-1 text-fg-subtle"
597595
>
598-
<span class="i-svg-spinners:ring-resize w-3 h-3" aria-hidden="true" />
596+
(<span class="i-svg-spinners:ring-resize w-3 h-3" aria-hidden="true" />)
599597
</span>
600-
<span v-else-if="totalDepsCount !== null">{{
601-
numberFormatter.format(totalDepsCount)
602-
}}</span>
603-
<span v-else class="text-fg-subtle">-</span>
598+
<span v-else-if="totalDepsCount !== null"
599+
><span class="text-fg-subtle">(</span
600+
>{{ numberFormatter.format(totalDepsCount)
601+
}}<span class="text-fg-subtle">)</span></span
602+
>
603+
<span v-else class="text-fg-subtle">(-)</span>
604604
<template #fallback>
605-
<span class="text-fg-subtle">-</span>
605+
<span class="text-fg-subtle">(-)</span>
606606
</template>
607607
</ClientOnly>
608608
</template>
@@ -652,20 +652,22 @@ const showSkeleton = shallowRef(false)
652652
<span v-else>-</span>
653653
</span>
654654

655-
<!-- Separator and install size -->
655+
<!-- Total install size in parens -->
656656
<template v-if="displayVersion?.dist?.unpackedSize !== installSize?.totalSize">
657-
<span class="text-fg-subtle mx-1">/</span>
658-
659-
<span
660-
v-if="installSizeStatus === 'pending'"
661-
class="inline-flex items-center gap-1 text-fg-subtle"
662-
>
663-
<span class="i-svg-spinners:ring-resize w-3 h-3" aria-hidden="true" />
664-
</span>
665-
<span v-else-if="installSize?.totalSize" dir="ltr">
666-
{{ bytesFormatter.format(installSize.totalSize) }}
657+
<span class="ms-1">
658+
<span
659+
v-if="installSizeStatus === 'pending'"
660+
class="inline-flex items-center gap-1 text-fg-subtle"
661+
>
662+
(<span class="i-svg-spinners:ring-resize w-3 h-3" aria-hidden="true" />)
663+
</span>
664+
<span v-else-if="installSize?.totalSize" dir="ltr">
665+
<span class="text-fg-subtle">(</span
666+
>{{ bytesFormatter.format(installSize.totalSize)
667+
}}<span class="text-fg-subtle">)</span>
668+
</span>
669+
<span v-else class="text-fg-subtle">(-)</span>
667670
</span>
668-
<span v-else class="text-fg-subtle">-</span>
669671
</template>
670672
</dd>
671673
</div>

0 commit comments

Comments
 (0)