fix: remove the contributors only warning for connector (#1920)

Author: liangmiQwQ

app/components/Header/ConnectorModal.vue

@@ -27,22 +27,22 @@ function handleDisconnect() {
   disconnect()
 }
 
-// function copyCommand() {
-//   let command = executeNpmxConnectorCommand.value
-//   if (portInput.value !== '31415') {
-//     command += ` --port ${portInput.value}`
-//   }
-//   copy(command)
-// }
-
-// const selectedPM = useSelectedPackageManager()
-
-// const executeNpmxConnectorCommand = computed(() => {
-//   return getExecuteCommand({
-//     packageName: 'npmx-connector',
-//     packageManager: selectedPM.value,
-//   })
-// })
+function copyCommand() {
+  let command = executeNpmxConnectorCommand.value
+  if (portInput.value !== '31415') {
+    command += ` --port ${portInput.value}`
+  }
+  copy(command)
+}
+
+const selectedPM = useSelectedPackageManager()
+
+const executeNpmxConnectorCommand = computed(() => {
+  return getExecuteCommand({
+    packageName: 'npmx-connector',
+    packageManager: selectedPM.value,
+  })
+})
 </script>
 
 <template>
@@ -87,26 +87,6 @@ function handleDisconnect() {
 
     <!-- Disconnected state -->
     <form v-else class="space-y-4" @submit.prevent="handleConnect">
-      <!-- Contributor-only notice -->
-      <div class="p-3 bg-amber-500/10 border border-amber-500/30 rounded-lg">
-        <div>
-          <span class="inline-block text-xs font-bold uppercase tracking-wider text-fg rounded">
-            {{ $t('connector.modal.contributor_badge') }}
-          </span>
-          <p class="text-sm text-fg-muted">
-            <i18n-t keypath="connector.modal.contributor_notice" scope="global">
-              <template #link>
-                <LinkBase
-                  to="https://github.com/npmx-dev/npmx.dev/blob/main/CONTRIBUTING.md#local-connector-cli"
-                >
-                  {{ $t('connector.modal.contributor_link') }}
-                </LinkBase>
-              </template>
-            </i18n-t>
-          </p>
-        </div>
-      </div>
-
       <p class="text-sm text-fg-muted">
         {{ $t('connector.modal.run_hint') }}
       </p>
@@ -116,43 +96,20 @@ function handleDisconnect() {
         dir="ltr"
       >
         <span class="text-fg-subtle">$</span>
-        <span class="text-fg-subtle ms-2">npx npmx-connector</span>
-        <ButtonBase
-          :aria-label="copied ? $t('connector.modal.copied') : $t('connector.modal.copy_command')"
-          @click="copy('npx npmx-connector')"
-          class="ms-auto"
-          :classicon="copied ? 'i-lucide:check text-green-500' : 'i-lucide:copy'"
-        />
+        <span class="text-fg-subtle ms-2">{{ executeNpmxConnectorCommand }}</span>
+        <div class="ms-auto flex items-center gap-2">
+          <!-- Disable teleport in a modal dialog -->
+          <PackageManagerSelect :teleport="false" />
+
+          <ButtonBase
+            :aria-label="copied ? $t('connector.modal.copied') : $t('connector.modal.copy_command')"
+            @click="copyCommand"
+            class="ms-auto"
+            :classicon="copied ? 'i-lucide:check text-green-500' : 'i-lucide:copy'"
+          />
+        </div>
       </div>
 
-      <!-- TODO: Uncomment when npmx-connector is published to npm
-                    <div
-                      class="flex items-center p-3 bg-bg-muted border border-border rounded-lg font-mono text-sm"
-                    >
-                      <span class="text-fg-subtle">$</span>
-                      <span class="text-fg-subtle ms-2">{{ executeNpmxConnectorCommand }}</span>
-                      <div class="ms-auto flex items-center gap-2">
-                        <PackageManagerSelect />
-
-                        <button
-                          type="button"
-                          :aria-label="
-                            copied ? $t('connector.modal.copied') : $t('connector.modal.copy_command')
-                          "
-                          class="ms-auto text-fg-subtle p-1.5 -m-1.5 hover:text-fg transition-colors duration-200 focus-visible:outline-accent/70 rounded"
-                          @click="copyCommand"
-                        >
-                          <span v-if="!copied" class="i-lucide:copy block w-5 h-5" aria-hidden="true" />
-                          <span
-                            v-else
-                            class="i-lucide:check block w-5 h-5 text-green-500"
-                            aria-hidden="true"
-                          />
-                        </button>
-                      </div>
-                    </div>
-                    -->
-
       <p class="text-sm text-fg-muted">{{ $t('connector.modal.paste_token') }}</p>
 
       <div class="space-y-3">

app/components/Package/ManagerSelect.vue

@@ -1,6 +1,15 @@
 <script setup lang="ts">
 import { onClickOutside, useEventListener } from '@vueuse/core'
 
+withDefaults(
+  defineProps<{
+    teleport?: boolean
+  }>(),
+  {
+    teleport: true,
+  },
+)
+
 const selectedPM = useSelectedPackageManager()
 
 const listRef = useTemplateRef('listRef')
@@ -121,7 +130,7 @@ function handleKeydown(event: KeyboardEvent) {
   </button>
 
   <!-- Dropdown menu (teleported to body to avoid clipping) -->
-  <Teleport to="body">
+  <Teleport to="body" :disabled="!teleport">
     <Transition
       :enter-active-class="prefersReducedMotion ? '' : 'transition-opacity duration-150'"
       :enter-from-class="prefersReducedMotion ? '' : 'opacity-0'"

i18n/locales/ar.json

@@ -462,9 +462,6 @@
   "connector": {
     "modal": {
       "title": "الموصل المحلي",
-      "contributor_badge": "للمساهمين فقط",
-      "contributor_notice": "لم يُنشر الموصل بعد على npm. راجع {link} لمعرفة كيفية التشغيل محليًا.",
-      "contributor_link": "دليل المساهمة",
       "connected": "متصل",
       "connected_as_user": "متصل كـ ~{user}",
       "connected_hint": "يمكنك الآن إدارة الحزم والمؤسسات من واجهة الويب.",

i18n/locales/az-AZ.json

@@ -495,9 +495,6 @@
   "connector": {
     "modal": {
       "title": "Lokal Konnektor",
-      "contributor_badge": "Yalnız əməkdaşlar üçün",
-      "contributor_notice": "Konnektor hələ npm-ə dərc edilməyib. Lokal işə salmaq üçün {link} baxın.",
-      "contributor_link": "töhfə bələdçisi",
       "connected": "Qoşulub",
       "connected_as_user": "~{user} kimi qoşulub",
       "connected_hint": "İndi veb interfeysdən paketləri və təşkilatları idarə edə bilərsiniz.",

i18n/locales/bg-BG.json

@@ -533,9 +533,6 @@
   "connector": {
     "modal": {
       "title": "Локален конектор",
-      "contributor_badge": "Само за сътрудници",
-      "contributor_notice": "Конекторът все още не е публикуван в npm. Вижте {link} за как да го стартирате локално.",
-      "contributor_link": "ръководство за сътрудничество",
       "connected": "Свързан",
       "connected_as_user": "Свързан като ~{user}",
       "connected_hint": "Сега можете да управлявате пакети и организации от уеб интерфейса.",

i18n/locales/bn-IN.json

@@ -359,9 +359,6 @@
   "connector": {
     "modal": {
       "title": "স্থানীয় কনেক্টর",
-      "contributor_badge": "কন্ট্রিবিউটারদের জন্য মাত্র",
-      "contributor_notice": "কনেক্টর এখনো npm এ প্রকাশিত হয়নি। স্থানীয়ভাবে চালানোর জন্য {link} দেখুন।",
-      "contributor_link": "অবদানের নির্দেশনা",
       "connected": "সংযুক্ত হয়েছে",
       "connected_as_user": "~{user} হিসাবে সংযুক্ত",
       "connected_hint": "এখন আপনি ওয়েব UI থেকে প্যাকেজ এবং সংস্থাগুলি পরিচালনা করতে পারবেন।",

i18n/locales/cs-CZ.json

@@ -511,9 +511,6 @@
   "connector": {
     "modal": {
       "title": "Lokální konektor",
-      "contributor_badge": "Pouze přispěvatelé",
-      "contributor_notice": "Konektor ještě není publikován na npm. Viz {link} pro informace, jak jej spustit lokálně.",
-      "contributor_link": "příručka pro přispěvatele",
       "connected": "Připojeno",
       "connected_as_user": "Připojeno jako ~{user}",
       "connected_hint": "Nyní můžete spravovat balíčky a organizace z webového rozhraní.",

i18n/locales/de-DE.json

@@ -577,9 +577,6 @@
   "connector": {
     "modal": {
       "title": "Lokaler Connector",
-      "contributor_badge": "Nur für Mitwirkende",
-      "contributor_notice": "Der Connector ist noch nicht auf npm veröffentlicht. Siehe den {link} für Informationen zum lokalen Ausführen.",
-      "contributor_link": "Leitfaden für Mitwirkende",
       "connected": "Verbunden",
       "connected_as_user": "Verbunden als ~{user}",
       "connected_hint": "Du kannst jetzt Pakete und Organisationen über die Web-Oberfläche verwalten.",

i18n/locales/en.json

@@ -577,9 +577,6 @@
   "connector": {
     "modal": {
       "title": "Local Connector",
-      "contributor_badge": "Contributors only",
-      "contributor_notice": "The connector is not yet published to npm. See the {link} for how to run locally.",
-      "contributor_link": "contributing guide",
       "connected": "Connected",
       "connected_as_user": "Connected as ~{user}",
       "connected_hint": "You can now manage packages and organizations from the web UI.",

i18n/locales/es.json

@@ -533,9 +533,6 @@
   "connector": {
     "modal": {
       "title": "Conector Local",
-      "contributor_badge": "Solo colaboradores",
-      "contributor_notice": "El conector aún no está publicado en npm. Consulta la {link} para saber cómo ejecutarlo localmente.",
-      "contributor_link": "guía de contribución",
       "connected": "Conectado",
       "connected_as_user": "Conectado como ~{user}",
       "connected_hint": "Ahora puedes gestionar paquetes y organizaciones desde la interfaz web.",