fix: track active provider for npm fallback pagination and guard cache against stale username

Author: danielroe

app/composables/npm/useUserPackages.ts

@@ -30,6 +30,10 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
   // --- Incremental loading state (npm path) ---
   const currentPage = shallowRef(1)
 
+  /** Tracks which provider actually served the current data (may differ from
+   *  searchProvider when Algolia returns empty and we fall through to npm) */
+  const activeProvider = shallowRef<'npm' | 'algolia'>(searchProvider.value)
+
   const cache = shallowRef<{
     username: string
     objects: NpmSearchResult[]
@@ -62,6 +66,7 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
           // registry which uses `maintainer:` search (matches all maintainers,
           // not just the primary owner that Algolia's owner.name indexes).
           if (response.objects.length > 0) {
+            activeProvider.value = 'algolia'
             cache.value = {
               username: user,
               objects: response.objects,
@@ -74,7 +79,8 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
         }
       }
 
-      // --- npm registry: initial page ---
+      // --- npm registry: initial page (or Algolia fallback) ---
+      activeProvider.value = 'npm'
       cache.value = null
       currentPage.value = 1
 
@@ -110,8 +116,8 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
    */
   async function fetchMore(manageLoadingState = true): Promise<void> {
     const user = toValue(username)
-    const provider = searchProvider.value
-    if (!user || provider !== 'npm') return
+    // Use activeProvider: if Algolia fell through to npm, we still need pagination
+    if (!user || activeProvider.value !== 'npm') return
 
     if (cache.value && cache.value.username !== user) {
       cache.value = null
@@ -142,7 +148,7 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
       )
 
       // Guard against stale response
-      if (user !== toValue(username) || provider !== searchProvider.value) return
+      if (user !== toValue(username) || activeProvider.value !== 'npm') return
 
       if (cache.value && cache.value.username === user) {
         const existingNames = new Set(cache.value.objects.map(obj => obj.package.name))
@@ -185,16 +191,18 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
     }
   }
 
-  // asyncdata will automatically rerun due to key, but we need to reset caache/page
+  // asyncdata will automatically rerun due to key, but we need to reset cache/page
   // when provider changes
-  watch(searchProvider, () => {
+  watch(searchProvider, newProvider => {
     cache.value = null
     currentPage.value = 1
+    activeProvider.value = newProvider
   })
 
-  // Computed data that uses cache
+  // Computed data that uses cache (only if it belongs to the current username)
   const data = computed<NpmSearchResponse | null>(() => {
-    if (cache.value) {
+    const user = toValue(username)
+    if (cache.value && cache.value.username === user) {
       return {
         isStale: false,
         objects: cache.value.objects,
@@ -207,8 +215,8 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
 
   /** Whether there are more results available to load (npm path only) */
   const hasMore = computed(() => {
-    // Non-npm providers fetch everything in one request
-    if (searchProvider.value !== 'npm') return false
+    // Algolia fetches everything in one request; only npm needs pagination
+    if (activeProvider.value !== 'npm') return false
     if (!cache.value) return true
     // npm path: more available if we haven't hit the server total or our cap
     const fetched = cache.value.objects.length