Skip to content

Commit 70f7615

Browse files
feat: add title for disabled input
1 parent da70124 commit 70f7615

7 files changed

Lines changed: 20 additions & 6 deletions

File tree

app/components/Package/Card.vue

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,18 @@ const numberFormatter = useNumberFormatter()
6868
<div class="relative z-1">
6969
<label>
7070
<span class="sr-only"> {{ $t('package.card.select') }}: {{ result.package.name }} </span>
71+
7172
<input
7273
data-package-card-checkbox
7374
class="md:opacity-0 group-focus-within:opacity-100 checked:opacity-100 md:group-hover:opacity-100 size-4 cursor-pointer accent-accent border border-fg-muted/30 hover:border-accent transition-colors disabled:opacity-30 disabled:cursor-not-allowed"
7475
type="checkbox"
7576
:checked="isSelected"
7677
:disabled="isMaxSelected && !isSelected"
77-
:title="isMaxSelected && !isSelected ? 'Maximum 4 packages can be selected' : undefined"
78+
:title="
79+
isMaxSelected && !isSelected
80+
? $t('package.card.select_maximum', MAX_PACKAGE_SELECTION)
81+
: undefined
82+
"
7883
@change="togglePackageSelection(result.package.name)"
7984
/>
8085
</label>

app/components/Package/SelectionView.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ const { data, pending } = useAsyncData(
5656

5757
<p class="text-fg-muted text-sm font-mono">
5858
{{ $t('action_bar.selection', selectedPackages.length) }}
59-
<span class="text-accent">— Compare up to 4 packages</span>
6059
</p>
6160

6261
<div class="mt-6">

app/components/Package/TableRow.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,11 @@ const allMaintainersText = computed(() => {
213213
type="checkbox"
214214
:checked="isSelected"
215215
:disabled="isMaxSelected && !isSelected"
216-
:title="isMaxSelected && !isSelected ? 'Maximum 4 packages can be selected' : undefined"
216+
:title="
217+
isMaxSelected && !isSelected
218+
? $t('package.card.select_maximum', MAX_PACKAGE_SELECTION)
219+
: undefined
220+
"
217221
@change="togglePackageSelection(result.package.name)"
218222
/>
219223
</label>

i18n/locales/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,8 @@
310310
"weekly_downloads": "Weekly downloads",
311311
"keywords": "Keywords",
312312
"license": "License",
313-
"select": "Select package"
313+
"select": "Select package",
314+
"select_maximum": "Maximum {count} packages can be selected"
314315
},
315316
"versions": {
316317
"title": "Versions",

i18n/schema.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -936,6 +936,9 @@
936936
},
937937
"select": {
938938
"type": "string"
939+
},
940+
"select_maximum": {
941+
"type": "string"
939942
}
940943
},
941944
"additionalProperties": false

lunaria/files/en-GB.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,8 @@
309309
"weekly_downloads": "Weekly downloads",
310310
"keywords": "Keywords",
311311
"license": "License",
312-
"select": "Select package"
312+
"select": "Select package",
313+
"select_maximum": "Maximum {count} packages can be selected"
313314
},
314315
"versions": {
315316
"title": "Versions",

lunaria/files/en-US.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,8 @@
309309
"weekly_downloads": "Weekly downloads",
310310
"keywords": "Keywords",
311311
"license": "License",
312-
"select": "Select package"
312+
"select": "Select package",
313+
"select_maximum": "Maximum {count} packages can be selected"
313314
},
314315
"versions": {
315316
"title": "Versions",

0 commit comments

Comments
 (0)