fixing some (minor) things caught by coderabbitai

Author: WilcoSp

app/components/Changelog/Card.vue

@@ -9,7 +9,7 @@ const formattedDate = useDateFormat(() => release.publishedAt, 'YYYY-MM-DD', {})
 
 const cardId = computed(() => (release.publishedAt ? `date-${formattedDate.value}` : undefined))
 
-const navId = computed(() => `releaae-${encodeURIComponent(release.title)}`)
+const navId = computed(() => `release-${encodeURIComponent(release.title)}`)
 
 function navigateToTitle() {
   navigateTo(`#${navId.value}`)
@@ -28,10 +28,10 @@ function navigateToTitle() {
           {{ release.title }}
         </a>
       </h2>
-      <TagStatic v-if="release.prerelease" variant="default" :tabindex="0" class="h-unset">
+      <TagStatic v-if="release.prerelease" variant="default" class="h-unset">
         {{ $t('changelog.pre_release') }}
       </TagStatic>
-      <TagStatic v-if="release.draft" variant="default" :tabindex="0" class="h-unset">
+      <TagStatic v-if="release.draft" variant="default" class="h-unset">
         {{ $t('changelog.draft') }}
       </TagStatic>
       <div class="flex-1" aria-hidden="true"></div>

app/components/Changelog/Markdown.vue

@@ -7,11 +7,7 @@ const { info, tpTarget } = defineProps<{
 const { data } = useLazyFetch(() => `/api/changelog/md/${info.provider}/${info.repo}/${info.path}`)
 </script>
 <template>
-  <Teleport
-    v-if="data?.toc && data.toc.length > 1 && !!tpTarget"
-    :to="tpTarget"
-    class="flex justify-end mt-3"
-  >
+  <Teleport v-if="data?.toc && data.toc.length > 1 && !!tpTarget" :to="tpTarget">
     <ReadmeTocDropdown :toc="data.toc" class="justify-self-end" />
   </Teleport>
   <Readme v-if="data?.html" :html="data.html"></Readme>

app/composables/useProviderIcon.ts

@@ -1,6 +1,8 @@
+import type { ProviderId } from '#imports'
 import type { IconClass } from '~/types/icon'
+import { computed, toValue } from 'vue'
 
-const PROVIDER_ICONS: Record<string, IconClass> = {
+const PROVIDER_ICONS: Record<ProviderId, IconClass> = {
   github: 'i-simple-icons:github',
   gitlab: 'i-simple-icons:gitlab',
   bitbucket: 'i-simple-icons:bitbucket',

app/pages/package-changes/[...path].vue

@@ -108,14 +108,14 @@ const tptoc = useTemplateRef('tptoc')
       </div>
     </header>
 
-    <section class="container w-full" v-if="changelog">
-      <LazyChangelogReleases v-if="changelog.type == 'release'" :info="changelog" />
+    <section class="container w-full" v-if="!pending">
+      <LazyChangelogReleases v-if="changelog?.type == 'release'" :info="changelog" />
       <LazyChangelogMarkdown
-        v-else-if="changelog.type == 'md'"
+        v-else-if="changelog?.type == 'md'"
         :info="changelog"
         :tpTarget="tptoc"
       />
-      <p v-else-if="!pending" class="mt-5">{{ $t('changelog.no_logs') }}</p>
+      <p class="mt-5">{{ $t('changelog.no_logs') }}</p>
     </section>
   </main>
 </template>

i18n/locales/en.json

@@ -1200,6 +1200,6 @@
   "changelog": {
     "pre_release": "Pre-release",
     "draft": "Draft",
-    "no_logs": "Sorry, this package doesn't track any changelogs or their method of trackings changes isn't supported"
+    "no_logs": "Sorry, this package does not publish changelogs, or its changelog format is not supported."
   }
 }

lunaria/files/en-GB.json

@@ -1165,6 +1165,6 @@
   "changelog": {
     "pre_release": "Pre-release",
     "draft": "Draft",
-    "no_logs": "Sorry, this package doesn't track any changelogs or their method of trackings changes isn't supported"
+    "no_logs": "Sorry, this package does not publish changelogs, or its changelog format is not supported."
   }
 }

lunaria/files/en-US.json

@@ -1165,6 +1165,6 @@
   "changelog": {
     "pre_release": "Pre-release",
     "draft": "Draft",
-    "no_logs": "Sorry, this package doesn't track any changelogs or their method of trackings changes isn't supported"
+    "no_logs": "Sorry, this package does not publish changelogs, or its changelog format is not supported."
   }
 }

server/utils/changelog/markdown.ts

@@ -25,7 +25,7 @@ export async function changelogRenderer(mdRepoInfo: MarkdownRepoInfo) {
     const titleAttr = title ? ` title="${title}"` : ''
     const plainText = text.replace(/<[^>]*>/g, '').trim()
 
-    if (href.startsWith('mailto:') && !EMAIL_REGEX.test(text)) {
+    if (href.startsWith('mailto:') && !EMAIL_REGEX.test(plainText)) {
       return text
     }
 
@@ -260,15 +260,22 @@ function resolveUrl(url: string, repoInfo: MarkdownRepoInfo) {
   // Check if this is a markdown file link
   const isMarkdownFile = /\.md$/i.test(url.split('?')[0]?.split('#')[0] ?? '')
 
+  // if (url.startsWith('./') || url.startsWith('../')) {
+  //   // url constructor handles relative paths
+  //   return checkResolvedUrl(new URL(url, `${baseUrl}/${repoInfo.path ?? ''}`).href, baseUrl)
+  // }
+
   const baseUrl = isMarkdownFile ? repoInfo.blobBaseUrl : repoInfo.rawBaseUrl
-  if (url.startsWith('./') || url.startsWith('../')) {
-    // url constructor handles relative paths
-    return checkResolvedUrl(new URL(url, `${baseUrl}/${repoInfo.path ?? ''}`).href, baseUrl)
-  }
+
   if (url.startsWith('/')) {
     return checkResolvedUrl(new URL(`${baseUrl}${url}`).href, baseUrl)
   }
 
+  if (!hasProtocol(url)) {
+    // the '/' ensure bare relative links stay after "....../HEAD"
+    return checkResolvedUrl(new URL(url, `${baseUrl}/${repoInfo.path ?? '/'}`).href, baseUrl)
+  }
+
   return url
 }