Skip to content

Commit 784b8db

Browse files
committed
Merge remote-tracking branch 'upstream/main' into fix-a11y-extract-btn-component
2 parents 77903fc + 6bbbd85 commit 784b8db

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+195
-157
lines changed

app/components/Compare/ComparisonGrid.vue

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
import type { ModuleReplacement } from 'module-replacements'
33
44
export interface ComparisonGridColumn {
5-
/** Display text (e.g. "lodash@4.17.21") */
6-
header: string
5+
name: string
6+
version?: string
77
/** Module replacement data for this package (if available) */
88
replacement?: ModuleReplacement | null
99
}
@@ -38,18 +38,14 @@ function getReplacementTooltip(col: ComparisonGridColumn): string {
3838
<div class="comparison-label" />
3939

4040
<!-- Package columns -->
41-
<div
42-
v-for="col in columns"
43-
:key="col.header"
44-
class="comparison-cell comparison-cell-header"
45-
>
41+
<div v-for="col in columns" :key="col.name" class="comparison-cell comparison-cell-header">
4642
<span class="inline-flex items-center gap-1.5 truncate">
4743
<NuxtLink
48-
:to="packageRoute(col.header)"
44+
:to="packageRoute(col.name, col.version)"
4945
class="link-subtle font-mono text-sm font-medium text-fg truncate"
50-
:title="col.header"
46+
:title="col.version ? `${col.name}@${col.version}` : col.name"
5147
>
52-
{{ col.header }}
48+
{{ col.name }}<template v-if="col.version">@{{ col.version }}</template>
5349
</NuxtLink>
5450
<TooltipApp v-if="col.replacement" :text="getReplacementTooltip(col)" position="bottom">
5551
<span

app/components/Compare/FacetCard.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,9 @@ function getShortName(header: string): string {
131131
:datetime="value.display"
132132
date-style="medium"
133133
/>
134-
<template v-else>{{ value.display }}</template>
134+
<template v-else>
135+
<span dir="auto">{{ value.display }}</span>
136+
</template>
135137
</span>
136138
</template>
137139
</span>

app/components/Compare/FacetRow.vue

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,9 @@ function isCellLoading(index: number): boolean {
135135
>
136136
<!-- Date values use DateTime component for i18n and user settings -->
137137
<DateTime v-if="value.type === 'date'" :datetime="value.display" date-style="medium" />
138-
<template v-else>{{ value.display }}</template>
138+
<template v-else>
139+
<span dir="auto">{{ value.display }}</span>
140+
</template>
139141
</span>
140142
</TooltipApp>
141143
<span
@@ -146,7 +148,9 @@ function isCellLoading(index: number): boolean {
146148
>
147149
<!-- Date values use DateTime component for i18n and user settings -->
148150
<DateTime v-if="value.type === 'date'" :datetime="value.display" date-style="medium" />
149-
<template v-else>{{ value.display }}</template>
151+
<template v-else>
152+
<span dir="auto">{{ value.display }}</span>
153+
</template>
150154
</span>
151155
</template>
152156
</div>

app/components/Header/ConnectorModal.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ function handleDisconnect() {
108108

109109
<div
110110
class="flex items-center p-3 bg-bg-muted border border-border rounded-lg font-mono text-sm"
111+
dir="ltr"
111112
>
112113
<span class="text-fg-subtle">$</span>
113114
<span class="text-fg-subtle ms-2">pnpm npmx-connector</span>

app/components/OgImage/Default.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ interface Props {
88
const props = withDefaults(defineProps<Props>(), {
99
primaryColor: '#60a5fa',
1010
title: 'npmx',
11-
description: 'A better browser for the **npm registry**',
11+
description: 'a fast, modern browser for the **npm registry**',
1212
})
1313
</script>
1414

app/components/Package/Card.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ const pkgDescription = useMarkdown(() => ({
4848
:prefetch-on="prefetch ? 'visibility' : 'interaction'"
4949
class="decoration-none scroll-mt-48 scroll-mb-6 after:content-[''] after:absolute after:inset-0"
5050
:data-result-index="index"
51+
dir="ltr"
5152
>{{ result.package.name }}</NuxtLink
5253
>
5354
<span

app/components/Package/Compatibility.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const sortedEngines = computed(() => {
4848
/>
4949
{{ getName(engine) }}
5050
</dt>
51-
<dd class="font-mono text-sm text-fg text-end" :title="version">
51+
<dd class="font-mono text-sm text-fg text-end" :title="version" dir="ltr">
5252
{{ version }}
5353
</dd>
5454
</div>

app/components/Package/Dependencies.vue

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@ const sortedOptionalDependencies = computed(() => {
8181
:key="dep"
8282
class="flex items-center justify-between py-1 text-sm gap-2"
8383
>
84-
<LinkBase :to="packageRoute(dep)">
84+
<LinkBase :to="packageRoute(dep)" dir="ltr">
8585
{{ dep }}
8686
</LinkBase>
87-
<span class="flex items-center gap-1 max-w-[40%]">
87+
<span class="flex items-center gap-1 max-w-[40%]" dir="ltr">
8888
<span
8989
v-if="outdatedDeps[dep]"
9090
class="shrink-0"
@@ -161,7 +161,7 @@ const sortedOptionalDependencies = computed(() => {
161161
class="flex items-center justify-between py-1 text-sm gap-1 min-w-0"
162162
>
163163
<div class="flex items-center gap-1 min-w-0 flex-1">
164-
<LinkBase :to="packageRoute(peer.name)" class="truncate">
164+
<LinkBase :to="packageRoute(peer.name)" class="truncate" dir="ltr">
165165
{{ peer.name }}
166166
</LinkBase>
167167
<TagStatic v-if="peer.optional" :title="$t('package.dependencies.optional')">
@@ -172,6 +172,7 @@ const sortedOptionalDependencies = computed(() => {
172172
:to="packageRoute(peer.name, peer.version)"
173173
class="truncate"
174174
:title="peer.version"
175+
dir="ltr"
175176
>
176177
{{ peer.version }}
177178
</LinkBase>
@@ -213,10 +214,10 @@ const sortedOptionalDependencies = computed(() => {
213214
:key="dep"
214215
class="flex items-center justify-between py-1 text-sm gap-2"
215216
>
216-
<LinkBase :to="packageRoute(dep)" class="truncate">
217+
<LinkBase :to="packageRoute(dep)" class="truncate" dir="ltr">
217218
{{ dep }}
218219
</LinkBase>
219-
<LinkBase :to="packageRoute(dep, version)" class="truncate" :title="version">
220+
<LinkBase :to="packageRoute(dep, version)" class="truncate" :title="version" dir="ltr">
220221
{{ version }}
221222
</LinkBase>
222223
</li>

app/components/Package/Maintainers.vue

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,13 @@ watch(
190190
params: { username: maintainer.name },
191191
}"
192192
class="link-subtle font-mono text-sm shrink-0"
193+
dir="ltr"
193194
>
194195
~{{ maintainer.name }}
195196
</LinkBase>
196-
<span v-else class="font-mono text-sm text-fg-muted">{{ maintainer.email }}</span>
197+
<span v-else class="font-mono text-sm text-fg-muted" dir="ltr">{{
198+
maintainer.email
199+
}}</span>
197200

198201
<!-- Access source badges -->
199202
<span

app/components/Package/TableRow.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,15 @@ const allMaintainersText = computed(() => {
5353
<NuxtLink
5454
:to="packageUrl"
5555
class="font-mono text-sm text-fg hover:text-accent-fallback transition-colors duration-200"
56+
dir="ltr"
5657
>
5758
{{ pkg.name }}
5859
</NuxtLink>
5960
</td>
6061

6162
<!-- Version -->
6263
<td v-if="isColumnVisible('version')" class="py-2 px-3 font-mono text-xs text-fg-subtle">
63-
{{ pkg.version }}
64+
<span dir="ltr">{{ pkg.version }}</span>
6465
</td>
6566

6667
<!-- Description -->

0 commit comments

Comments
 (0)