added scroll preservation opt in to the compare page to avoid input updates resetting it

Author: mihaizaurus

app/pages/compare.vue

@@ -5,6 +5,7 @@ import FacetBarChart from '~/components/Compare/FacetBarChart.vue'
 
 definePageMeta({
   name: 'compare',
+  preserveScrollOnQuery: true,
 })
 
 const { locale } = useI18n()

app/router.options.ts

@@ -7,6 +7,17 @@ export default {
     if (savedPosition) {
       return savedPosition
     }
+
+    // Preserve the current viewport for query-only updates on pages that opt in,
+    // such as compare where controls sync state to the URL in-place.
+    if (
+      to.path === _from.path &&
+      to.hash === _from.hash &&
+      to.meta.preserveScrollOnQuery === true
+    ) {
+      return false
+    }
+
     // If navigating to a hash anchor, scroll to it
     if (to.hash) {
       const { scrollMargin } = to.meta

test/unit/app/router.options.spec.ts

@@ -0,0 +1,54 @@
+import { describe, expect, it } from 'vitest'
+import routerOptions from '../../../app/router.options'
+
+function createRoute(overrides: Record<string, unknown> = {}) {
+  return {
+    path: '/',
+    hash: '',
+    meta: {},
+    ...overrides,
+  } as any
+}
+
+describe('router scrollBehavior', () => {
+  it('restores saved position when available', () => {
+    const savedPosition = { left: 12, top: 345 }
+
+    expect(routerOptions.scrollBehavior(createRoute(), createRoute(), savedPosition)).toEqual(
+      savedPosition,
+    )
+  })
+
+  it('preserves scroll on query-only updates for pages that opt in', () => {
+    const to = createRoute({
+      path: '/compare',
+      meta: { preserveScrollOnQuery: true },
+    })
+    const from = createRoute({
+      path: '/compare',
+      meta: { preserveScrollOnQuery: true },
+    })
+
+    expect(routerOptions.scrollBehavior(to, from, null)).toBe(false)
+  })
+
+  it('scrolls to hash anchors', () => {
+    const to = createRoute({
+      hash: '#section-function',
+      meta: { scrollMargin: 96 },
+    })
+
+    expect(routerOptions.scrollBehavior(to, createRoute(), null)).toEqual({
+      el: '#section-function',
+      behavior: 'smooth',
+      top: 96,
+    })
+  })
+
+  it('scrolls to top for regular navigations', () => {
+    const to = createRoute({ path: '/compare', meta: { preserveScrollOnQuery: true } })
+    const from = createRoute({ path: '/search' })
+
+    expect(routerOptions.scrollBehavior(to, from, null)).toEqual({ left: 0, top: 0 })
+  })
+})