refactor: batch pds-users.get.ts requests

Author: Kai-ros

app/pages/pds.vue

@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import type { AtprotoProfile } from '#server/api/atproto/users.get.ts'
+import type { AtprotoProfile } from '#server/api/atproto/pds-users.get.ts'
 
 const router = useRouter()
 const canGoBack = useCanGoBack()

server/api/atproto/pds-users.get.ts

@@ -1,54 +1,53 @@
-export interface AtprotoProfile {
-  did: string
-  handle: string
-  displayName?: string
-  avatar?: string
-}
+import {
+  ONE_THOUSAND_NPMX_USER_ACCOUNTS_XRPC,
+  BSKY_APP_VIEW_USER_PROFILES_XRPC,
+  ERROR_PDS_FETCH_FAILED,
+} from '#shared/utils/constants'
+import type { AtprotoProfile } from '#shared/types/atproto'
+
+const USER_BATCH_AMOUNT = 25
 
 export default defineCachedEventHandler(
   async (): Promise<AtprotoProfile[]> => {
-    const response = await fetch('https://npmx.social/xrpc/com.atproto.sync.listRepos?limit=1000')
+    // INFO: Request npmx.social PDS for every hosted user account
+    const response = await fetch(ONE_THOUSAND_NPMX_USER_ACCOUNTS_XRPC)
 
     if (!response.ok) {
       throw createError({
         statusCode: response.status,
-        message: 'Failed to fetch PDS repos',
+        message: ERROR_PDS_FETCH_FAILED,
       })
     }
 
     const listRepos = (await response.json()) as { repos: { did: string }[] }
     const dids = listRepos.repos.map(repo => repo.did)
 
-    const getProfilesUrl = 'https://public.api.bsky.app/xrpc/app.bsky.actor.getProfiles'
-    const allProfiles: AtprotoProfile[] = []
-
-    for (let i = 0; i < dids.length; i += 25) {
-      const batch = dids.slice(i, i + 25)
-
-      const params = new URLSearchParams()
-      for (const did of batch) {
-        params.append('actors', did)
-      }
-
-      try {
-        const profilesResponse = await fetch(`${getProfilesUrl}?${params.toString()}`)
-
-        if (!profilesResponse.ok) {
-          console.warn(`Failed to fetch atproto profiles: ${profilesResponse.status}`)
-          continue
-        }
-
-        const profilesData = (await profilesResponse.json()) as { profiles: AtprotoProfile[] }
-
-        if (profilesData.profiles) {
-          allProfiles.push(...profilesData.profiles)
-        }
-      } catch (error) {
-        console.warn('Failed to fetch atproto profiles:', error)
-      }
+    // INFO: Request the list of user profiles from the Bluesky AppView
+    const batchPromises: Promise<AtprotoProfile[]>[] = []
+
+    for (let i = 0; i < dids.length; i += USER_BATCH_AMOUNT) {
+      const batch = dids.slice(i, i + USER_BATCH_AMOUNT)
+      const url = new URL(BSKY_APP_VIEW_USER_PROFILES_XRPC)
+
+      for (const did of batch) url.searchParams.append('actors', did)
+
+      batchPromises.push(
+        fetch(url.toString())
+          .then(res => {
+            if (!res.ok) throw new Error(`Status ${res.status}`)
+            return res.json() as Promise<{ profiles: AtprotoProfile[] }>
+          })
+          .then(data => data.profiles || [])
+          .catch(err => {
+            console.warn('Failed to fetch batch:', err)
+            // Return empty array on failure so Promise.all doesn't crash
+            return []
+          }),
+      )
     }
 
-    return allProfiles
+    // INFO: Await all batches in parallel and flatten the results
+    return (await Promise.all(batchPromises)).flat()
   },
   {
     maxAge: 3600,

shared/types/atproto.ts

@@ -0,0 +1,13 @@
+/**
+ * The lightweight view of a public profile for an AT Protocol user
+ */
+export type AtprotoProfile = {
+  // The unique Decentralized Identifier (DID)
+  did: string
+  // User handle (e.g. user.bsky.social or user.com)
+  handle: string
+  // Display name, if present
+  displayName?: string
+  // URL of the avatar image, if present
+  avatar?: string
+}

shared/utils/constants.ts

@@ -14,6 +14,12 @@ export const BLUESKY_API = 'https://public.api.bsky.app'
 export const BLUESKY_COMMENTS_REQUEST = '/api/atproto/bluesky-comments'
 export const NPM_REGISTRY = 'https://registry.npmjs.org'
 export const NPM_API = 'https://api.npmjs.org'
+export const ONE_THOUSAND_NPMX_USER_ACCOUNTS_XRPC =
+  'https://npmx.social/xrpc/com.atproto.sync.listRepos?limit=1000'
+export const BSKY_APP_VIEW_USER_PROFILES_XRPC =
+  'https://public.api.bsky.app/xrpc/app.bsky.actor.getProfiles'
+
+// Error Messages
 export const ERROR_PACKAGE_ANALYSIS_FAILED = 'Failed to analyze package.'
 export const ERROR_PACKAGE_VERSION_AND_FILE_FAILED = 'Version and file path are required.'
 export const ERROR_PACKAGE_REQUIREMENTS_FAILED =
@@ -25,6 +31,7 @@ export const NPM_MISSING_README_SENTINEL = 'ERROR: No README data found!'
 export const NPM_README_TRUNCATION_THRESHOLD = 64_000
 export const ERROR_JSR_FETCH_FAILED = 'Failed to fetch package from JSR registry.'
 export const ERROR_NPM_FETCH_FAILED = 'Failed to fetch package from npm registry.'
+export const ERROR_PDS_FETCH_FAILED = 'Failed to fetch PDS repos.'
 export const ERROR_PROVENANCE_FETCH_FAILED = 'Failed to fetch provenance.'
 export const UNSET_NUXT_SESSION_PASSWORD = 'NUXT_SESSION_PASSWORD not set'
 export const ERROR_SUGGESTIONS_FETCH_FAILED = 'Failed to fetch suggestions.'