Skip to content

Commit 7c8a637

Browse files
fix: redundant mobile menu close logic (#992)
1 parent 0531e3f commit 7c8a637

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

app/components/AppHeader.vue

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -185,19 +185,14 @@ onKeyStroke(
185185
<HeaderAccountMenu />
186186
</div>
187187

188-
<!-- Mobile: Menu button (always visible, toggles menu) -->
188+
<!-- Mobile: Menu button (always visible, click to open menu) -->
189189
<button
190190
type="button"
191191
class="sm:hidden flex items-center p-2 -m-2 text-fg-subtle hover:text-fg transition-colors duration-200 focus-visible:outline-accent/70 rounded"
192-
:aria-label="showMobileMenu ? $t('common.close') : $t('nav.open_menu')"
193-
:aria-expanded="showMobileMenu"
194-
@click="showMobileMenu = !showMobileMenu"
192+
:aria-label="$t('nav.open_menu')"
193+
@click="showMobileMenu = true"
195194
>
196-
<span
197-
class="w-6 h-6 inline-block"
198-
:class="showMobileMenu ? 'i-carbon:close' : 'i-carbon:menu'"
199-
aria-hidden="true"
200-
/>
195+
<span class="w-6 h-6 inline-block i-carbon:menu" aria-hidden="true" />
201196
</button>
202197
</div>
203198
</nav>

0 commit comments

Comments
 (0)