fix typing issues & add guards for potential undefined types

Author: bdbch

app/components/AppHeader.vue

@@ -52,7 +52,6 @@ const mobileLinks = computed<NavigationConfigWithGroups>(() => [
         name: 'About',
         label: $t('footer.about'),
         to: { name: 'about' },
-        keyshortcut: null,
         type: 'link',
         external: false,
         iconClass: 'i-carbon:information',
@@ -61,7 +60,6 @@ const mobileLinks = computed<NavigationConfigWithGroups>(() => [
         name: 'Privacy Policy',
         label: $t('privacy_policy.title'),
         to: { name: 'privacy' },
-        keyshortcut: null,
         type: 'link',
         external: false,
         iconClass: 'i-carbon:security',
@@ -81,7 +79,6 @@ const mobileLinks = computed<NavigationConfigWithGroups>(() => [
         label: $t('footer.docs'),
         href: 'https://docs.npmx.dev',
         target: '_blank',
-        keyshortcut: null,
         type: 'link',
         external: true,
         iconClass: 'i-carbon:document',
@@ -91,7 +88,6 @@ const mobileLinks = computed<NavigationConfigWithGroups>(() => [
         label: $t('footer.source'),
         href: 'https://repo.npmx.dev',
         target: '_blank',
-        keyshortcut: null,
         type: 'link',
         external: true,
         iconClass: 'i-carbon:logo-github',
@@ -101,7 +97,6 @@ const mobileLinks = computed<NavigationConfigWithGroups>(() => [
         label: $t('footer.social'),
         href: 'https://social.npmx.dev',
         target: '_blank',
-        keyshortcut: null,
         type: 'link',
         external: true,
         iconClass: 'i-simple-icons:bluesky',
@@ -111,7 +106,6 @@ const mobileLinks = computed<NavigationConfigWithGroups>(() => [
         label: $t('footer.chat'),
         href: 'https://chat.npmx.dev',
         target: '_blank',
-        keyshortcut: null,
         type: 'link',
         external: true,
         iconClass: 'i-carbon:chat',
@@ -176,7 +170,7 @@ onKeyStroke(
     }
 
     for (const link of desktopLinks.value) {
-      if (isKeyWithoutModifiers(e, link.keyshortcut)) {
+      if (link.to && link.keyshortcut && isKeyWithoutModifiers(e, link.keyshortcut)) {
         e.preventDefault()
         navigateTo(link.to.name)
         break

app/components/Header/MobileMenu.client.vue

@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import { useFocusTrap } from '@vueuse/integrations/useFocusTrap'
 import { useAtproto } from '~/composables/atproto/useAtproto'
+import type { NavigationConfigWithGroups } from '~/types'
 
 const isOpen = defineModel<boolean>('open', { default: false })
 const { links } = defineProps<{
@@ -178,8 +179,12 @@ onUnmounted(deactivate)
 
             <!-- Navigation links -->
             <div class="flex-1 overflow-y-auto overscroll-contain py-2">
-              <template v-for="group in links">
-                <div v-if="group.type === 'separator'" class="mx-4 my-2 border-t border-border" />
+              <template v-for="(group, index) in links">
+                <div
+                  v-if="group.type === 'separator'"
+                  :key="`seperator-${index}`"
+                  class="mx-4 my-2 border-t border-border"
+                />
 
                 <div v-if="group.type === 'group'" :key="group.name" class="p-2">
                   <span
@@ -192,7 +197,7 @@ onUnmounted(deactivate)
                     <NuxtLink
                       v-for="link in group.items"
                       :key="link.name"
-                      :to="link.to"
+                      :to="link.to?.name"
                       :href="link.href"
                       :target="link.target"
                       class="flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200"