Merge branch 'main' into feat/add-versions-modal-permalink

alexdln · web-flow · commit 809de341c5b2 · 2026-02-23T14:02:36.000Z
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -289,18 +289,6 @@ import { hasProtocol } from 'ufo'
 | Constants        | SCREAMING_SNAKE_CASE     | `NPM_REGISTRY`, `ALLOWED_TAGS` |
 | Types/Interfaces | PascalCase               | `NpmSearchResponse`            |
 
-> [!TIP]
-> Exports in `app/composables/`, `app/utils/`, and `server/utils/` are auto-imported by Nuxt. To prevent [knip](https://knip.dev/) from flagging them as unused, add a `@public` JSDoc annotation:
->
-> ```typescript
-> /**
->  * @public
->  */
-> export function myAutoImportedFunction() {
->   // ...
-> }
-> ```
-
 ### Vue components
 
 - Use Composition API with `<script setup lang="ts">`
diff --git a/app/composables/useActiveTocItem.ts b/app/composables/useActiveTocItem.ts
@@ -7,7 +7,6 @@ import type { Ref } from 'vue'
  *
  * @param toc - Reactive array of TOC items
  * @returns Object containing activeId
- * @public
  */
 export function useActiveTocItem(toc: Ref<TocItem[]>) {
   const activeId = shallowRef<string | null>(null)
diff --git a/app/composables/useMarkdown.ts b/app/composables/useMarkdown.ts
@@ -8,7 +8,6 @@ interface UseMarkdownOptions {
   packageName?: string
 }
 
-/** @public */
 export function useMarkdown(options: MaybeRefOrGetter<UseMarkdownOptions>) {
   return computed(() => parseMarkdown(toValue(options)))
 }
diff --git a/modules/runtime/server/cache.ts b/modules/runtime/server/cache.ts
@@ -195,6 +195,44 @@ function getMockForUrl(url: string): MockResult | null {
     return { data: null }
   }
 
+  // npm attestations API - return empty attestations (provenance not needed in tests)
+  if (host === 'registry.npmjs.org' && pathname.startsWith('/-/npm/v1/attestations/')) {
+    return { data: { attestations: [] } }
+  }
+
+  // Constellation API - return empty results for link queries
+  if (host === 'constellation.microcosm.blue') {
+    if (pathname === '/links/distinct-dids') {
+      return { data: { total: 0, linking_dids: [], cursor: undefined } }
+    }
+    if (pathname === '/links/all') {
+      return { data: { links: {} } }
+    }
+    if (pathname === '/xrpc/blue.microcosm.links.getBacklinks') {
+      return { data: { total: 0, records: [], cursor: undefined } }
+    }
+    return { data: null }
+  }
+
+  // UNGH (GitHub proxy) - return mock repo metadata
+  if (host === 'ungh.cc') {
+    const repoMatch = pathname.match(/^\/repos\/([^/]+)\/([^/]+)$/)
+    if (repoMatch?.[1] && repoMatch?.[2]) {
+      return {
+        data: {
+          repo: {
+            description: `${repoMatch[1]}/${repoMatch[2]} - mock repo description`,
+            stars: 1000,
+            forks: 100,
+            watchers: 50,
+            defaultBranch: 'main',
+          },
+        },
+      }
+    }
+    return { data: null }
+  }
+
   // GitHub API - handled via fixtures, return null to use fixture system
   // Note: The actual fixture loading is handled in fetchFromFixtures via special case
   if (host === 'api.github.com') {
@@ -426,6 +464,19 @@ async function handleGitHubApi(
     return { data: [] }
   }
 
+  // Commits endpoint: /repos/{owner}/{repo}/commits
+  const commitsMatch = pathname.match(/^\/repos\/([^/]+)\/([^/]+)\/commits$/)
+  if (commitsMatch) {
+    // Return a single-item array; fetchPageCount will use body.length when no Link header
+    return { data: [{ sha: 'mock-commit' }] }
+  }
+
+  // Search endpoint: /search/issues, /search/commits, etc.
+  const searchMatch = pathname.match(/^\/search\/(.+)$/)
+  if (searchMatch) {
+    return { data: { total_count: 0, incomplete_results: false, items: [] } }
+  }
+
   // Other GitHub API endpoints can be added here as needed
   return null
 }
diff --git a/nuxt.config.ts b/nuxt.config.ts
@@ -1,6 +1,6 @@
 import process from 'node:process'
 import { currentLocales } from './config/i18n'
-import { isCI, provider } from 'std-env'
+import { isCI, isTest, provider } from 'std-env'
 
 export default defineNuxtConfig({
   modules: [
@@ -216,6 +216,9 @@ export default defineNuxtConfig({
         include: ['../test/unit/server/**/*.ts'],
       },
     },
+    replace: {
+      'import.meta.test': isTest,
+    },
   },
 
   fonts: {
diff --git a/package.json b/package.json
@@ -132,7 +132,7 @@
     "knip": "5.83.0",
     "lint-staged": "16.2.7",
     "oxfmt": "0.27.0",
-    "oxlint": "1.49.0",
+    "oxlint": "1.50.0",
     "schema-dts": "1.1.5",
     "simple-git-hooks": "2.13.1",
     "typescript": "5.9.3",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/server/utils/atproto/oauth.ts b/server/utils/atproto/oauth.ts
@@ -19,20 +19,18 @@ export const handleResolver = new AtprotoDohHandleResolver({
 })
 
 export function getOauthClientMetadata() {
-  const dev = import.meta.dev
+  const redirect_uri = `${clientUri}/api/auth/atproto`
 
-  const client_uri = clientUri
-  const redirect_uri = `${client_uri}/api/auth/atproto`
-
-  const client_id = dev
-    ? `http://localhost?redirect_uri=${encodeURIComponent(redirect_uri)}&scope=${encodeURIComponent(scope)}`
-    : `${client_uri}/oauth-client-metadata.json`
+  const client_id =
+    import.meta.dev || import.meta.test
+      ? `http://localhost?redirect_uri=${encodeURIComponent(redirect_uri)}&scope=${encodeURIComponent(scope)}`
+      : `${clientUri}/oauth-client-metadata.json`
 
   // If anything changes here, please make sure to also update /shared/schemas/oauth.ts to match
   return parse(OAuthMetadataSchema, {
     client_name: 'npmx.dev',
     client_id,
-    client_uri,
+    client_uri: clientUri,
     scope,
     redirect_uris: [redirect_uri] as [string, ...string[]],
     grant_types: ['authorization_code', 'refresh_token'],
diff --git a/server/utils/provenance.ts b/server/utils/provenance.ts
@@ -90,7 +90,6 @@ function repoUrlToBlobUrl(repository: string, path: string, ref = 'main'): strin
 /**
  * Parse npm attestations API response into ProvenanceDetails.
  * Prefers SLSA provenance v1; falls back to v0.2 for provider label and ledger only (no source commit/build file from v0.2).
- * @public
  */
 export function parseAttestationToProvenanceDetails(response: unknown): ProvenanceDetails | null {
   const body = response as NpmAttestationsResponse
diff --git a/server/utils/skills.ts b/server/utils/skills.ts
@@ -73,7 +73,6 @@ export interface SkillDirInfo {
 /**
  * Find skill directories in a package file tree.
  * Returns skill names and their children for file counting.
- * @public
  */
 export function findSkillDirs(tree: PackageFileTree[]): SkillDirInfo[] {
   const skillsDir = tree.find(node => node.type === 'directory' && node.name === 'skills')
@@ -176,7 +175,6 @@ export function validateSkill(frontmatter: SkillFrontmatter): SkillWarning[] {
 
 /**
  * Fetch skill list with frontmatter for discovery endpoint.
- * @public
  */
 export async function fetchSkillsList(
   packageName: string,
@@ -215,7 +213,6 @@ export interface WellKnownSkillItem {
 
 /**
  * Fetch skill list for well-known index.json format (CLI compatibility).
- * @public
  */
 export async function fetchSkillsListForWellKnown(
   packageName: string,
diff --git a/shared/schemas/blog.ts b/shared/schemas/blog.ts
@@ -34,5 +34,4 @@ export interface ResolvedAuthor extends Author {
 /**
  * Inferred type for blog post frontmatter
  */
-/** @public */
 export type BlogPostFrontmatter = InferOutput<typeof BlogPostSchema>
diff --git a/shared/schemas/user.ts b/shared/schemas/user.ts
@@ -21,7 +21,5 @@ export const GravatarQuerySchema = v.object({
   username: NpmUsernameSchema,
 })
 
-/** @public */
 export type NpmUsername = v.InferOutput<typeof NpmUsernameSchema>
-/** @public */
 export type GravatarQuery = v.InferOutput<typeof GravatarQuerySchema>
diff --git a/shared/types/npm-registry.ts b/shared/types/npm-registry.ts
@@ -233,7 +233,6 @@ export interface NpmVersionDist {
 /**
  * Parsed provenance details for display (from attestation bundle SLSA predicate).
  * Used by the provenance API and PackageProvenanceSection.
- * @public
  */
 export interface ProvenanceDetails {
   /** Provider ID (e.g. "github", "gitlab") */
diff --git a/shared/utils/constants.ts b/shared/utils/constants.ts
@@ -31,9 +31,7 @@ export const ERROR_SUGGESTIONS_FETCH_FAILED = 'Failed to fetch suggestions.'
 export const ERROR_SKILLS_FETCH_FAILED = 'Failed to fetch skills.'
 export const ERROR_SKILL_NOT_FOUND = 'Skill not found.'
 export const ERROR_SKILL_FILE_NOT_FOUND = 'Skill file not found.'
-/** @public */
 export const ERROR_GRAVATAR_FETCH_FAILED = 'Failed to fetch Gravatar profile.'
-/** @public */
 export const ERROR_GRAVATAR_EMAIL_UNAVAILABLE = "User's email not accessible."
 export const ERROR_NEED_REAUTH = 'User needs to reauthenticate'
 
diff --git a/shared/utils/npm.ts b/shared/utils/npm.ts
@@ -52,7 +52,6 @@ export function assertValidPackageName(name: string): void {
 /**
  * Validate an npm username and throw an HTTP error if invalid.
  * Uses a regular expression to check against npm naming rules.
- * @public
  */
 export function assertValidUsername(username: string): void {
   if (!username || username.length > NPM_USERNAME_MAX_LENGTH || !NPM_USERNAME_RE.test(username)) {
diff --git a/test/e2e/og-image.spec.ts-snapshots/og-image-for--package-nuxt-v-3-20-2.png b/test/e2e/og-image.spec.ts-snapshots/og-image-for--package-nuxt-v-3-20-2.png
diff --git a/test/fixtures/mock-routes.cjs b/test/fixtures/mock-routes.cjs
@@ -124,6 +124,11 @@ function matchNpmRegistry(urlString) {
     return json({ error: 'Not found' }, 404)
   }
 
+  // Attestations endpoint - return empty attestations
+  if (pathname.startsWith('/-/npm/v1/attestations/')) {
+    return json({ attestations: [] })
+  }
+
   // Packument
   if (!pathname.startsWith('/-/')) {
     let packageName = pathname.slice(1)
@@ -440,6 +445,52 @@ function matchGravatarApi(_urlString) {
   return { status: 404, contentType: 'text/plain', body: 'Not found' }
 }
 
+/**
+ * @param {string} urlString
+ * @returns {MockResponse | null}
+ */
+function matchUnghApi(urlString) {
+  const url = new URL(urlString)
+
+  const repoMatch = url.pathname.match(/^\/repos\/([^/]+)\/([^/]+)$/)
+  if (repoMatch && repoMatch[1] && repoMatch[2]) {
+    return json({
+      repo: {
+        description: `${repoMatch[1]}/${repoMatch[2]} - mock repo description`,
+        stars: 1000,
+        forks: 100,
+        watchers: 50,
+        defaultBranch: 'main',
+      },
+    })
+  }
+
+  return json(null)
+}
+
+/**
+ * @param {string} urlString
+ * @returns {MockResponse | null}
+ */
+function matchConstellationApi(urlString) {
+  const url = new URL(urlString)
+
+  if (url.pathname === '/links/distinct-dids') {
+    return json({ total: 0, linking_dids: [], cursor: undefined })
+  }
+
+  if (url.pathname === '/links/all') {
+    return json({ links: {} })
+  }
+
+  if (url.pathname === '/xrpc/blue.microcosm.links.getBacklinks') {
+    return json({ total: 0, records: [], cursor: undefined })
+  }
+
+  // Unknown constellation endpoint - return empty
+  return json(null)
+}
+
 /**
  * @param {string} urlString
  * @returns {MockResponse | null}
@@ -454,6 +505,18 @@ function matchGitHubApi(urlString) {
     return json(fixture || [])
   }
 
+  // Commits endpoint
+  const commitsMatch = pathname.match(/^\/repos\/([^/]+)\/([^/]+)\/commits$/)
+  if (commitsMatch) {
+    return json([{ sha: 'mock-commit' }])
+  }
+
+  // Search endpoint (issues, commits, etc.)
+  const searchMatch = pathname.match(/^\/search\/(.+)$/)
+  if (searchMatch) {
+    return json({ total_count: 0, incomplete_results: false, items: [] })
+  }
+
   return null
 }
 
@@ -480,6 +543,12 @@ const routes = [
   },
   { name: 'Gravatar API', pattern: 'https://www.gravatar.com/**', match: matchGravatarApi },
   { name: 'GitHub API', pattern: 'https://api.github.com/**', match: matchGitHubApi },
+  { name: 'UNGH API', pattern: 'https://ungh.cc/**', match: matchUnghApi },
+  {
+    name: 'Constellation API',
+    pattern: 'https://constellation.microcosm.blue/**',
+    match: matchConstellationApi,
+  },
 ]
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@ import type { Ref } from 'vue'`
`7`	`7`	`*`
`8`	`8`	`* @param toc - Reactive array of TOC items`
`9`	`9`	`* @returns Object containing activeId`
`10`		`- * @public`
`11`	`10`	`*/`
`12`	`11`	`export function useActiveTocItem(toc: Ref<TocItem[]>) {`
`13`	`12`	`const activeId = shallowRef<string \| null>(null)`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ interface UseMarkdownOptions {`
`8`	`8`	`packageName?: string`
`9`	`9`	`}`
`10`	`10`
`11`		`-/** @public */`
`12`	`11`	`export function useMarkdown(options: MaybeRefOrGetter<UseMarkdownOptions>) {`
`13`	`12`	`return computed(() => parseMarkdown(toValue(options)))`
`14`	`13`	`}`