fix(readme): cancel unread jsdelivr batch responses on early return

Author: trivikr

server/utils/readme-loaders.ts

@@ -25,6 +25,13 @@ export function isStandardReadme(filename: string | undefined): boolean {
   return !!filename && standardReadmePattern.test(filename)
 }
 
+async function cancelUnreadBatchResponses(
+  responses: Array<Response | null>,
+  startIndex: number,
+): Promise<void> {
+  await Promise.allSettled(responses.slice(startIndex).map(response => response?.body?.cancel()))
+}
+
 function buildReadmeFetchCandidates(readmeFilename: string | undefined): string[] {
   return readmeFilename
     ? standardReadmeFilenames.filter(name => name !== readmeFilename)
@@ -60,9 +67,10 @@ export async function fetchReadmeFromJsdelivr(
       }),
     )
 
-    for (const response of responses) {
+    for (const [responseIndex, response] of responses.entries()) {
       const text = await response?.text()
       if (text?.trim()) {
+        await cancelUnreadBatchResponses(responses, responseIndex + 1)
         return text
       }
     }

test/unit/server/utils/readme-loaders.spec.ts

@@ -139,6 +139,7 @@ describe('fetchReadmeFromJsdelivr', () => {
   it('reads only the matched successful response body', async () => {
     const firstTextMock = vi.fn().mockResolvedValue('# First')
     const secondTextMock = vi.fn().mockResolvedValue('# Second')
+    const secondCancelMock = vi.fn().mockResolvedValue(undefined)
     const fetchMock = vi
       .fn()
       .mockResolvedValueOnce({
@@ -148,6 +149,9 @@ describe('fetchReadmeFromJsdelivr', () => {
       .mockResolvedValueOnce({
         ok: true,
         text: secondTextMock,
+        body: {
+          cancel: secondCancelMock,
+        },
       })
     vi.stubGlobal('fetch', fetchMock)
 
@@ -156,6 +160,7 @@ describe('fetchReadmeFromJsdelivr', () => {
     expect(result).toBe('# First')
     expect(firstTextMock).toHaveBeenCalledTimes(1)
     expect(secondTextMock).not.toHaveBeenCalled()
+    expect(secondCancelMock).toHaveBeenCalledTimes(1)
   })
 })