Skip to content

Commit 86530fc

Browse files
committed
fix(AppPopover): a11y issues
1 parent 9c1c0fd commit 86530fc

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

app/components/AppPopover.vue

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,12 @@ onBeforeUnmount(clearCloseTimeout)
4646
<template>
4747
<div
4848
class="relative inline-flex"
49-
:aria-expanded="isOpen"
50-
:aria-haspopup="true"
51-
:aria-controls="isOpen ? popoverId : undefined"
5249
@mouseenter="open"
5350
@mouseleave="close"
5451
@focusin="open"
5552
@focusout="close"
5653
>
57-
<slot :popover-visible="isOpen" />
54+
<slot :popover-visible="isOpen" :popover-id="popoverId" />
5855

5956
<Transition
6057
enter-active-class="transition-opacity duration-150 motion-reduce:transition-none"
@@ -67,7 +64,7 @@ onBeforeUnmount(clearCloseTimeout)
6764
:id="popoverId"
6865
role="dialog"
6966
aria-modal="false"
70-
class="absolute font-mono text-xs text-fg bg-bg-elevated border border-border rounded-lg shadow-lg z-[100] pointer-events-auto px-4 py-3 min-w-[14rem] max-w-[22rem] whitespace-normal"
67+
class="absolute font-mono text-xs text-fg bg-bg-subtle border border-border rounded-lg shadow-lg z-[100] pointer-events-auto px-4 py-3 min-w-[14rem] max-w-[22rem] whitespace-normal"
7168
:class="panelPosition"
7269
@mouseenter="open"
7370
@mouseleave="close"

0 commit comments

Comments
 (0)