fix(a11y): use native checkboxes for compare facet selector

PhyPhy07 · PhyPhy07 · commit 86eeb6a877eb · 2026-03-24T13:58:10.000-05:00
diff --git a/app/components/Compare/FacetSelector.vue b/app/components/Compare/FacetSelector.vue
@@ -19,7 +19,7 @@ function isFacetCheckboxDisabled(facet: FacetInfoWithLabels): boolean {
 }
 
 function onFacetChange(facet: FacetInfoWithLabels) {
- if(isFacetCheckboxDisabled(facet)) return
+  if (isFacetCheckboxDisabled(facet)) return
   toggleFacet(facet.id)
 }
 
diff --git a/test/nuxt/components/compare/FacetSelector.spec.ts b/test/nuxt/components/compare/FacetSelector.spec.ts
@@ -42,9 +42,6 @@ const categoryLabels: Record<string, string> = {
 }
 
 const comingSoonFacetId = comingSoonFacets[0]
-const comingSoonFacetLabel = hasComingSoonFacets
-  ? (facetLabels[comingSoonFacetId!]?.label ?? comingSoonFacetId)
-  : ''
 
 // Helper to build facet info with labels
 function buildFacetInfo(facet: ComparisonFacet) {

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ function isFacetCheckboxDisabled(facet: FacetInfoWithLabels): boolean {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`function onFacetChange(facet: FacetInfoWithLabels) {`
`22`		`- if(isFacetCheckboxDisabled(facet)) return`
	`22`	`+ if (isFacetCheckboxDisabled(facet)) return`
`23`	`23`	`toggleFacet(facet.id)`
`24`	`24`	`}`
`25`	`25`
Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,6 @@ const categoryLabels: Record<string, string> = {`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`const comingSoonFacetId = comingSoonFacets[0]`
`45`		`-const comingSoonFacetLabel = hasComingSoonFacets`
`46`		`- ? (facetLabels[comingSoonFacetId!]?.label ?? comingSoonFacetId)`
`47`		`- : ''`
`48`	`45`
`49`	`46`	`// Helper to build facet info with labels`
`50`	`47`	`function buildFacetInfo(facet: ComparisonFacet) {`