Skip to content

Commit 876aaee

Browse files
knowlerrshigg
andauthored
refactor: use an <article> element for for package readme (#524)
Co-authored-by: Rshig <90143161+rshigg@users.noreply.github.com>
1 parent 6b93e22 commit 876aaee

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

app/components/PackageSkeleton.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
</div>
151151

152152
<!-- Sidebar: order-1 lg:order-2 space-y-8 -->
153-
<aside class="order-1 lg:order-2 space-y-8">
153+
<div class="order-1 lg:order-2 space-y-8">
154154
<!-- Maintainers -->
155155
<section>
156156
<h2
@@ -249,7 +249,7 @@
249249
</li>
250250
</ul>
251251
</section>
252-
</aside>
252+
</div>
253253
</div>
254254
</article>
255255
</template>

app/pages/[...package].vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -907,7 +907,7 @@ function handleClick(event: MouseEvent) {
907907
</a>
908908
</h2>
909909
<!-- eslint-disable vue/no-v-html -- HTML is sanitized server-side -->
910-
<div
910+
<article
911911
v-if="readmeData?.html"
912912
class="readme-content prose prose-invert max-w-[70ch]"
913913
v-html="readmeData.html"
@@ -923,7 +923,7 @@ function handleClick(event: MouseEvent) {
923923

924924
<div class="area-sidebar">
925925
<!-- Sidebar -->
926-
<aside class="sticky top-20 space-y-6 sm:space-y-8 min-w-0 overflow-hidden">
926+
<div class="sticky top-20 space-y-6 sm:space-y-8 min-w-0 overflow-hidden">
927927
<!-- Maintainers (with admin actions when connected) -->
928928
<PackageMaintainers :package-name="pkg.name" :maintainers="pkg.maintainers" />
929929

@@ -1031,7 +1031,7 @@ function handleClick(event: MouseEvent) {
10311031
:peer-dependencies-meta="displayVersion.peerDependenciesMeta"
10321032
:optional-dependencies="displayVersion.optionalDependencies"
10331033
/>
1034-
</aside>
1034+
</div>
10351035
</div>
10361036
</article>
10371037

0 commit comments

Comments
 (0)