Skip to content

Commit 8928c5a

Browse files
committed
fix: address review issues
1 parent 7425e0a commit 8928c5a

6 files changed

Lines changed: 27 additions & 11 deletions

File tree

app/components/Compare/FacetCard.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,9 @@ function getShortName(header: string): string {
131131
:datetime="value.display"
132132
date-style="medium"
133133
/>
134-
<template v-else>{{ value.display }}</template>
134+
<template v-else>
135+
<span dir="auto">{{ value.display }}</span>
136+
</template>
135137
</span>
136138
</template>
137139
</span>

app/components/Compare/FacetRow.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,9 @@ function isCellLoading(index: number): boolean {
135135
>
136136
<!-- Date values use DateTime component for i18n and user settings -->
137137
<DateTime v-if="value.type === 'date'" :datetime="value.display" date-style="medium" />
138-
<template v-else>{{ value.display }}</template>
138+
<template v-else>
139+
<span dir="ltr">{{ value.display }}</span>
140+
</template>
139141
</span>
140142
</TooltipApp>
141143
<span

app/components/Package/Dependencies.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ const sortedOptionalDependencies = computed(() => {
244244
<NuxtLink
245245
:to="{ name: 'package', params: { package: dep.split('/') } }"
246246
class="font-mono text-fg-muted hover:text-fg transition-colors duration-200 truncate min-w-0 flex-1"
247+
dir="ltr"
247248
>
248249
{{ dep }}
249250
</NuxtLink>
@@ -254,6 +255,7 @@ const sortedOptionalDependencies = computed(() => {
254255
}"
255256
class="font-mono text-xs text-fg-subtle max-w-[40%] text-end truncate"
256257
:title="version"
258+
dir="ltr"
257259
>
258260
{{ version }}
259261
</NuxtLink>

app/components/Package/Maintainers.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,9 @@ watch(
194194
>
195195
~{{ maintainer.name }}
196196
</NuxtLink>
197-
<span v-else class="font-mono text-sm text-fg-muted">{{ maintainer.email }}</span>
197+
<span v-else class="font-mono text-sm text-fg-muted" dir="ltr">{{
198+
maintainer.email
199+
}}</span>
198200

199201
<!-- Access source badges -->
200202
<span

app/components/Package/TableRow.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const allMaintainersText = computed(() => {
6161

6262
<!-- Version -->
6363
<td v-if="isColumnVisible('version')" class="py-2 px-3 font-mono text-xs text-fg-subtle">
64-
{{ pkg.version }}
64+
<span dir="ltr">{{ pkg.version }}</span>
6565
</td>
6666

6767
<!-- Description -->

app/components/Package/Versions.vue

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -375,14 +375,15 @@ function getTagVersions(tag: string): VersionDisplay[] {
375375
})
376376
: row.primaryVersion.version
377377
"
378-
dir="ltr"
379378
>
380379
<span
381380
v-if="row.primaryVersion.deprecated"
382381
class="i-carbon-warning-hex w-3.5 h-3.5 shrink-0"
383382
aria-hidden="true"
384383
/>
385-
{{ row.primaryVersion.version }}
384+
<span dir="ltr">
385+
{{ row.primaryVersion.version }}
386+
</span>
386387
</NuxtLink>
387388
</div>
388389
<div v-if="row.tags.length" class="flex items-center gap-1 mt-0.5 flex-wrap">
@@ -435,14 +436,15 @@ function getTagVersions(tag: string): VersionDisplay[] {
435436
? $t('package.versions.deprecated_title', { version: v.version })
436437
: v.version
437438
"
438-
dir="ltr"
439439
>
440440
<span
441441
v-if="v.deprecated"
442442
class="i-carbon-warning-hex w-3 h-3 shrink-0"
443443
aria-hidden="true"
444444
/>
445-
{{ v.version }}
445+
<span dir="ltr">
446+
{{ v.version }}
447+
</span>
446448
</NuxtLink>
447449
<div class="flex items-center gap-2 shrink-0">
448450
<DateTime
@@ -547,7 +549,9 @@ function getTagVersions(tag: string): VersionDisplay[] {
547549
class="i-carbon-warning-hex w-3 h-3 shrink-0"
548550
aria-hidden="true"
549551
/>
550-
{{ row.primaryVersion.version }}
552+
<span dir="ltr">
553+
{{ row.primaryVersion.version }}
554+
</span>
551555
</NuxtLink>
552556
<div class="flex items-center gap-2 shrink-0 pe-2">
553557
<DateTime
@@ -686,7 +690,9 @@ function getTagVersions(tag: string): VersionDisplay[] {
686690
class="i-carbon-warning-hex w-3 h-3 shrink-0"
687691
aria-hidden="true"
688692
/>
689-
{{ group.versions[0]?.version }}
693+
<span dir="ltr">
694+
{{ group.versions[0]?.version }}
695+
</span>
690696
</NuxtLink>
691697
</div>
692698
<div class="flex items-center gap-2 shrink-0 pe-2">
@@ -743,7 +749,9 @@ function getTagVersions(tag: string): VersionDisplay[] {
743749
class="i-carbon-warning-hex w-3 h-3 shrink-0"
744750
aria-hidden="true"
745751
/>
746-
{{ v.version }}
752+
<span dir="ltr">
753+
{{ v.version }}
754+
</span>
747755
</NuxtLink>
748756
<div class="flex items-center gap-2 shrink-0 pe-2">
749757
<DateTime

0 commit comments

Comments
 (0)