Skip to content

Commit 8b3c1ba

Browse files
committed
fix: correct bg picker state detection
1 parent 3e8fefa commit 8b3c1ba

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

app/components/Settings/BgThemePicker.vue

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,22 @@ const { backgroundThemes, selectedBackgroundTheme, setBackgroundTheme } = useBac
33
44
onPrehydrate(el => {
55
const settings = JSON.parse(localStorage.getItem('npmx-settings') || '{}')
6+
const defaultId = 'neutral'
67
const id = settings.preferredBackgroundTheme
78
if (id) {
89
const input = el.querySelector<HTMLInputElement>(`input[value="${id}"]`)
910
if (input) {
1011
input.checked = true
1112
input.setAttribute('checked', '')
1213
}
14+
// Remove checked from the server-default (clear button, value="")
15+
if (id !== defaultId) {
16+
const clearInput = el.querySelector<HTMLInputElement>(`input[value="${defaultId}"]`)
17+
if (clearInput) {
18+
clearInput.checked = false
19+
clearInput.removeAttribute('checked')
20+
}
21+
}
1322
}
1423
})
1524
</script>
@@ -30,7 +39,10 @@ onPrehydrate(el => {
3039
name="background-theme"
3140
class="sr-only"
3241
:value="theme.id"
33-
:checked="selectedBackgroundTheme === theme.id"
42+
:checked="
43+
selectedBackgroundTheme === theme.id ||
44+
(!selectedBackgroundTheme && theme.id === 'neutral')
45+
"
3446
:aria-label="theme.name"
3547
@change="setBackgroundTheme(theme.id)"
3648
/>

0 commit comments

Comments
 (0)