Skip to content

Commit 8bca677

Browse files
committed
fix(package-readme): avoid premature empty state and add loading/error handling
1 parent 752f8f7 commit 8bca677

31 files changed

+70
-30
lines changed

app/pages/package/[[org]]/[name].vue

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,6 +1040,16 @@ const showSkeleton = shallowRef(false)
10401040

10411041
<!-- eslint-disable vue/no-v-html -- HTML is sanitized server-side -->
10421042
<Readme v-if="readmeData?.html" :html="readmeData.html" />
1043+
<p
1044+
v-else-if="readmeStatus === 'pending'"
1045+
class="flex items-center gap-2 text-fg-subtle italic"
1046+
>
1047+
<span class="i-svg-spinners:ring-resize w-4 h-4" aria-hidden="true" />
1048+
<span>{{ $t('common.loading') }}…</span>
1049+
</p>
1050+
<p v-else-if="readmeStatus === 'error'" class="text-fg-muted italic">
1051+
{{ $t('package.readme.error_loading') }}
1052+
</p>
10431053
<p
10441054
v-else-if="readmeStatus === 'success' && !readmeData?.html"
10451055
class="text-fg-muted italic"

i18n/locales/ar.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,8 @@
259259
"warning": "تحذير",
260260
"caution": "تنبيه"
261261
},
262-
"copy_as_markdown": "نسخ README كـ Markdown"
262+
"copy_as_markdown": "نسخ README كـ Markdown",
263+
"error_loading": "فشل تحميل تفاصيل ملف README"
263264
},
264265
"provenance_section": {
265266
"title": "إثبات المصدر",

i18n/locales/az-AZ.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,8 @@
324324
"warning": "Xəbərdarlıq",
325325
"caution": "Diqqət"
326326
},
327-
"copy_as_markdown": "README-ni Markdown olaraq kopyala"
327+
"copy_as_markdown": "README-ni Markdown olaraq kopyala",
328+
"error_loading": "README təfərrüatları yüklənə bilmədi"
328329
},
329330
"provenance_section": {
330331
"title": "Mənşə",

i18n/locales/bg-BG.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,8 @@
287287
"warning": "Предупреждение",
288288
"caution": "Внимание"
289289
},
290-
"copy_as_markdown": "Копиране на README като Markdown"
290+
"copy_as_markdown": "Копиране на README като Markdown",
291+
"error_loading": "Неуспешно зареждане на детайлите за README"
291292
},
292293
"provenance_section": {
293294
"title": "Произход",

i18n/locales/bn-IN.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,8 @@
207207
"readme": {
208208
"title": "রিডমি",
209209
"no_readme": "README উপলব্ধ নেই।",
210-
"callout": {}
210+
"callout": {},
211+
"error_loading": "README বিবরণ লোড করা যায়নি"
211212
},
212213
"provenance_section": {},
213214
"security_downgrade": {},

i18n/locales/cs-CZ.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,8 @@
480480
"warning": "Varování",
481481
"caution": "Upozornění"
482482
},
483-
"copy_as_markdown": "Zkopírovat ČTI MĚ jako Markdown"
483+
"copy_as_markdown": "Zkopírovat ČTI MĚ jako Markdown",
484+
"error_loading": "Nepodařilo se načíst podrobnosti README"
484485
},
485486
"provenance_section": {
486487
"title": "Původ",

i18n/locales/de.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,8 @@
363363
"warning": "Warnung",
364364
"caution": "Vorsicht"
365365
},
366-
"copy_as_markdown": "README als Markdown kopieren"
366+
"copy_as_markdown": "README als Markdown kopieren",
367+
"error_loading": "Fehler beim Laden der README-Details"
367368
},
368369
"provenance_section": {
369370
"title": "Herkunftsnachweis",

i18n/locales/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,8 @@
480480
"warning": "Warning",
481481
"caution": "Caution"
482482
},
483-
"copy_as_markdown": "Copy README as Markdown"
483+
"copy_as_markdown": "Copy README as Markdown",
484+
"error_loading": "Failed to load README details"
484485
},
485486
"provenance_section": {
486487
"title": "Provenance",

i18n/locales/es-419.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@
4747
},
4848
"package": {
4949
"readme": {
50-
"title": "Léame"
50+
"title": "Léame",
51+
"error_loading": "Error al cargar los detalles del README"
5152
},
5253
"access": {
5354
"grant_button": "otorgar",

i18n/locales/es.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,8 @@
364364
"warning": "Advertencia",
365365
"caution": "Precaución"
366366
},
367-
"copy_as_markdown": "Copiar README como Markdown"
367+
"copy_as_markdown": "Copiar README como Markdown",
368+
"error_loading": "Error al cargar los detalles del README"
368369
},
369370
"provenance_section": {
370371
"title": "Procedencia",

0 commit comments

Comments
 (0)