Skip to content

Commit 9537d6e

Browse files
authored
fix: correctly exclude primary version from expanded tag list (#1802)
1 parent 6ee0a4a commit 9537d6e

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

app/components/Package/Versions.vue

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -427,9 +427,10 @@ function getTagVersions(tag: string): VersionDisplay[] {
427427
return tagVersions.value.get(tag) ?? []
428428
}
429429
430-
// Get filtered versions for a tag (applies semver filter when active)
431-
function getFilteredTagVersions(tag: string): VersionDisplay[] {
432-
const versions = getTagVersions(tag)
430+
// Get the expanded child versions for a tag row (excludes the primary version shown in the row header,
431+
// and applies semver filter when active)
432+
function getExpandedTagVersions(tag: string, primaryVersion: string): VersionDisplay[] {
433+
const versions = getTagVersions(tag).filter(v => v.version !== primaryVersion)
433434
if (!isFilterActive.value) return versions
434435
return versions.filter(v => filteredVersionSet.value.has(v.version))
435436
}
@@ -670,11 +671,14 @@ function majorGroupContainsCurrent(group: (typeof otherMajorGroups.value)[0]): b
670671

671672
<!-- Expanded versions -->
672673
<div
673-
v-if="expandedTags.has(row.tag) && getFilteredTagVersions(row.tag).length > 1"
674+
v-if="
675+
expandedTags.has(row.tag) &&
676+
getExpandedTagVersions(row.tag, row.primaryVersion.version).length
677+
"
674678
class="ms-4 ps-2 border-is border-border space-y-0.5 pe-2"
675679
>
676680
<div
677-
v-for="v in getFilteredTagVersions(row.tag).slice(1)"
681+
v-for="v in getExpandedTagVersions(row.tag, row.primaryVersion.version)"
678682
:key="v.version"
679683
class="py-1 relative group/version-row hover:bg-bg-elevated/20 focus-within:bg-bg-elevated/20 transition-colors duration-200"
680684
:class="v.version === effectiveCurrentVersion ? 'bg-bg-elevated/20 rounded' : ''"

0 commit comments

Comments
 (0)