Skip to content

Commit 98aec51

Browse files
committed
chore: show skeleton when status is idle + only throw when resolved version fetch has succeeded
1 parent 5f12b83 commit 98aec51

File tree

1 file changed

+18
-9
lines changed

1 file changed

+18
-9
lines changed

app/pages/package/[[org]]/[name].vue

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -210,15 +210,24 @@ const { data: skillsData } = useLazyFetch<SkillsListResponse>(
210210
const { data: packageAnalysis } = usePackageAnalysis(packageName, requestedVersion)
211211
const { data: moduleReplacement } = useModuleReplacement(packageName)
212212
213-
const { data: resolvedVersion } = await useResolvedVersion(packageName, requestedVersion)
213+
const { data: resolvedVersion, status: resolvedStatus } = await useResolvedVersion(
214+
packageName,
215+
requestedVersion,
216+
)
214217
215-
if (resolvedVersion.value === null) {
216-
throw createError({
217-
statusCode: 404,
218-
statusMessage: $t('package.not_found'),
219-
message: $t('package.not_found_message'),
220-
})
221-
}
218+
watch(
219+
[resolvedStatus, resolvedVersion],
220+
([status, version]) => {
221+
if (version === null && status === 'success') {
222+
throw createError({
223+
statusCode: 404,
224+
statusMessage: $t('package.not_found'),
225+
message: $t('package.not_found_message'),
226+
})
227+
}
228+
},
229+
{ immediate: true },
230+
)
222231
223232
const {
224233
data: pkg,
@@ -672,7 +681,7 @@ const showSkeleton = shallowRef(false)
672681
</ButtonBase>
673682
</DevOnly>
674683
<main class="container flex-1 w-full py-8">
675-
<PackageSkeleton v-if="showSkeleton || status === 'pending'" />
684+
<PackageSkeleton v-if="showSkeleton || status === 'idle' || status === 'pending'" />
676685

677686
<article v-else-if="status === 'success' && pkg" :class="$style.packagePage">
678687
<!-- Package header -->

0 commit comments

Comments
 (0)