Skip to content

Commit 9ae076e

Browse files
committed
fix: remove hashtags from some comparison labels for consistency
1 parent 306d537 commit 9ae076e

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

i18n/locales/en.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -878,11 +878,11 @@
878878
"description": "Total install size including all dependencies"
879879
},
880880
"dependencies": {
881-
"label": "# Direct Deps",
881+
"label": "Direct Deps",
882882
"description": "Number of direct dependencies"
883883
},
884884
"totalDependencies": {
885-
"label": "# Total Deps",
885+
"label": "Total Deps",
886886
"description": "Total number of dependencies including transitive"
887887
},
888888
"downloads": {

i18n/locales/zh-CN.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -878,11 +878,11 @@
878878
"description": "包括所有依赖项的总安装大小"
879879
},
880880
"dependencies": {
881-
"label": "# 直接依赖项",
881+
"label": "直接依赖项",
882882
"description": "直接依赖项数量"
883883
},
884884
"totalDependencies": {
885-
"label": "# 总依赖项",
885+
"label": "总依赖项",
886886
"description": "包括所有依赖项的总依赖项数量"
887887
},
888888
"downloads": {

lunaria/files/en-US.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -878,11 +878,11 @@
878878
"description": "Total install size including all dependencies"
879879
},
880880
"dependencies": {
881-
"label": "# Direct Deps",
881+
"label": "Direct Deps",
882882
"description": "Number of direct dependencies"
883883
},
884884
"totalDependencies": {
885-
"label": "# Total Deps",
885+
"label": "Total Deps",
886886
"description": "Total number of dependencies including transitive"
887887
},
888888
"downloads": {

lunaria/files/zh-CN.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -878,11 +878,11 @@
878878
"description": "包括所有依赖项的总安装大小"
879879
},
880880
"dependencies": {
881-
"label": "# 直接依赖项",
881+
"label": "直接依赖项",
882882
"description": "直接依赖项数量"
883883
},
884884
"totalDependencies": {
885-
"label": "# 总依赖项",
885+
"label": "总依赖项",
886886
"description": "包括所有依赖项的总依赖项数量"
887887
},
888888
"downloads": {

test/nuxt/components/compare/FacetSelector.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ const facetLabels: Record<ComparisonFacet, { label: string; description: string
1919
vulnerabilities: { label: 'Vulnerabilities', description: 'Known security vulnerabilities' },
2020
lastUpdated: { label: 'Published', description: 'When this version was published' },
2121
license: { label: 'License', description: 'Package license' },
22-
dependencies: { label: '# Direct Deps', description: 'Number of direct dependencies' },
22+
dependencies: { label: 'Direct Deps', description: 'Number of direct dependencies' },
2323
totalDependencies: {
24-
label: '# Total Deps',
24+
label: 'Total Deps',
2525
description: 'Total number of dependencies including transitive',
2626
},
2727
deprecated: { label: 'Deprecated?', description: 'Whether the package is deprecated' },
@@ -180,7 +180,7 @@ describe('FacetSelector', () => {
180180

181181
// totalDependencies is marked as comingSoon
182182
const buttons = component.findAll('button')
183-
const comingSoonButton = buttons.find(b => b.text().includes('# Total Deps'))
183+
const comingSoonButton = buttons.find(b => b.text().includes('Total Deps'))
184184

185185
expect(comingSoonButton?.attributes('disabled')).toBeDefined()
186186
})
@@ -196,7 +196,7 @@ describe('FacetSelector', () => {
196196

197197
// Find the comingSoon button
198198
const buttons = component.findAll('button')
199-
const comingSoonButton = buttons.find(b => b.text().includes('# Total Deps'))
199+
const comingSoonButton = buttons.find(b => b.text().includes('Total Deps'))
200200

201201
// Should not have checkmark or add icon
202202
expect(comingSoonButton?.find('.i-carbon\\:checkmark').exists()).toBe(false)
@@ -207,7 +207,7 @@ describe('FacetSelector', () => {
207207
const component = await mountSuspended(FacetSelector)
208208

209209
const buttons = component.findAll('button')
210-
const comingSoonButton = buttons.find(b => b.text().includes('# Total Deps'))
210+
const comingSoonButton = buttons.find(b => b.text().includes('Total Deps'))
211211
await comingSoonButton?.trigger('click')
212212

213213
// toggleFacet should not have been called with totalDependencies

0 commit comments

Comments
 (0)