refactor(compare): return null for missing or malformed GitHub metrics

Author: t128n

app/composables/usePackageComparison.ts

@@ -144,14 +144,14 @@ export function usePackageComparison(packageNames: MaybeRefOrGetter<string[]>) {
                 ? $fetch<{ repo: { stars: number } }>(
                     `https://ungh.cc/repos/${repoInfo.owner}/${repoInfo.repo}`,
                   )
-                    .then(res => res?.repo.stars || 0)
+                    .then(res => (typeof res?.repo?.stars === 'number' ? res.repo.stars : null))
                     .catch(() => null)
                 : Promise.resolve(null),
               isGitHub
-                ? $fetch<{ issues: number }>(
+                ? $fetch<{ issues: number | null }>(
                     `/api/github/issues/${repoInfo.owner}/${repoInfo.repo}`,
                   )
-                    .then(res => res?.issues || 0)
+                    .then(res => (typeof res?.issues === 'number' ? res.issues : null))
                     .catch(() => null)
                 : Promise.resolve(null),
             ])

server/api/github/issues/[owner]/[repo].get.ts

@@ -14,7 +14,7 @@ interface GitHubSearchResponse {
 export interface GithubIssueCountResponse {
   owner: string
   repo: string
-  issues: number
+  issues: number | null
 }
 
 export default defineCachedEventHandler(
@@ -46,7 +46,8 @@ export default defineCachedEventHandler(
           return {
             owner,
             repo,
-            issues: response._data?.total_count ?? 0,
+            issues:
+              typeof response._data?.total_count === 'number' ? response._data.total_count : null,
           }
         }
 

test/nuxt/composables/use-package-comparison.spec.ts

@@ -232,6 +232,43 @@ describe('usePackageComparison', () => {
       expect(issues).toMatchObject({ raw: 50, status: 'neutral' })
     })
 
+    it('returns null for missing or non-numeric github metrics', async () => {
+      const pkgName = 'missing-metrics-pkg'
+      vi.stubGlobal(
+        '$fetch',
+        vi.fn().mockImplementation((url: string, options?: { baseURL?: string }) => {
+          const fullUrl = options?.baseURL ? `${options.baseURL}${url}` : url
+          if (fullUrl.startsWith('https://registry.npmjs.org/')) {
+            return Promise.resolve({
+              'name': pkgName,
+              'dist-tags': { latest: '1.0.0' },
+              'repository': { type: 'git', url: 'https://github.com/owner/repo' },
+              'versions': {
+                '1.0.0': { dist: { unpackedSize: 1000 } },
+              },
+            })
+          }
+          if (fullUrl.includes('ungh.cc/repos/owner/repo')) {
+            // Return malformed data (stars missing)
+            return Promise.resolve({ repo: {} })
+          }
+          if (fullUrl.includes('/api/github/issues/owner/repo')) {
+            // Return non-numeric data
+            return Promise.resolve({ issues: 'not-a-number' })
+          }
+          return Promise.resolve(null)
+        }),
+      )
+
+      const { status, getFacetValues } = await usePackageComparisonInComponent([pkgName])
+      await vi.waitFor(() => {
+        expect(status.value).toBe('success')
+      })
+
+      expect(getFacetValues('githubStars')[0]).toBeNull()
+      expect(getFacetValues('githubIssues')[0]).toBeNull()
+    })
+
     it('skips github fetches for non-github repositories', async () => {
       const pkgName = 'gitlab-pkg'
       const fetchMock = vi