feat: set role prop to contributor object (+ change member list type to Set)

Author: shuuji3

server/api/contributors.get.ts

@@ -4,24 +4,22 @@ export interface GitHubContributor {
   avatar_url: string
   html_url: string
   contributions: number
+  role: Role
 }
 
 // TODO: stub - need to fetch list of role members from somewhere to avoid hardcoding (
-type Role = 'stewards' | 'core' | 'maintainers'
-const roleMembers: Record<Role, GitHubContributor['login'][]> = {
-  stewards: ['danielroe', 'patak-dev'],
-  core: [],
-  maintainers: [],
+type Role = 'stewards' | 'core' | 'maintainers' | 'contributor'
+const roleMembers: Record<Exclude<Role, 'contributor'>, Set<GitHubContributor['login']>> = {
+  stewards: new Set(['danielroe', 'patak-dev']),
+  core: new Set([]),
+  maintainers: new Set([]),
 }
 
-function getRoleOrder(login: GitHubContributor['login']) {
-  return roleMembers.stewards.includes(login)
-    ? 0
-    : roleMembers.core.includes(login)
-      ? 1
-      : roleMembers.maintainers.includes(login)
-        ? 2
-        : 3
+function getRoleInfo(login: string): { role: Role; order: number } {
+  if (roleMembers.stewards.has(login)) return { role: 'stewards', order: 0 }
+  if (roleMembers.core.has(login)) return { role: 'core', order: 1 }
+  if (roleMembers.maintainers.has(login)) return { role: 'maintainers', order: 2 }
+  return { role: 'contributor', order: 3 }
 }
 
 export default defineCachedEventHandler(
@@ -68,9 +66,14 @@ export default defineCachedEventHandler(
       allContributors
         // Filter out bots
         .filter(c => !c.login.includes('[bot]'))
-
+        // Assign role
+        .map(c => {
+          const { role, order } = getRoleInfo(c.login)
+          return Object.assign(c, { role, order })
+        })
         // Sort by role (steward > core > maintainer > contributor)
-        .sort((a, b) => getRoleOrder(a.login) - getRoleOrder(b.login))
+        .sort((a, b) => a.order - b.order)
+        .map(({ order: _, ...rest }) => rest)
     )
   },
   {