Skip to content

Commit a09e45c

Browse files
committed
chore: clean up PR scope, revert unrelated changes
Revert changes unrelated to OG image migration: - CI NODE_OPTIONS memory bump - site.description casing change - nitro prerender failOnError workaround - favicon.svg and logo-icon.svg branding changes - a11y test cosmetic string template refactoring
1 parent 295722d commit a09e45c

File tree

5 files changed

+24
-26
lines changed

5 files changed

+24
-26
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ jobs:
145145
run: pnpm vp run build:test
146146
env:
147147
VALIDATE_HTML: true
148-
NODE_OPTIONS: --max-old-space-size=6144
149148

150149
- name: 🖥️ Test project (browser)
151150
run: pnpm vp run test:browser:prebuilt
@@ -172,8 +171,6 @@ jobs:
172171

173172
- name: 🏗️ Build project
174173
run: pnpm vp run build:test
175-
env:
176-
NODE_OPTIONS: --max-old-space-size=6144
177174

178175
- name: ♿ Accessibility audit (Lighthouse - ${{ matrix.mode }} mode)
179176
run: pnpm vp run test:a11y:prebuilt

nuxt.config.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export default defineNuxtConfig({
8787
site: {
8888
url: 'https://npmx.dev',
8989
name: 'npmx',
90-
description: 'a fast, modern browser for the npm registry',
90+
description: 'A fast, modern browser for the npm registry',
9191
},
9292

9393
router: {
@@ -206,10 +206,6 @@ export default defineNuxtConfig({
206206
compatibilityDate: '2026-01-31',
207207

208208
nitro: {
209-
prerender: {
210-
// OAuth plugin crashes in CI/test (no valid clientUri), matching main branch behavior
211-
failOnError: !isTest,
212-
},
213209
externals: {
214210
inline: [
215211
'shiki',

public/favicon.svg

Lines changed: 9 additions & 2 deletions
Loading

public/logo-icon.svg

Lines changed: 0 additions & 6 deletions
This file was deleted.

test/unit/a11y-component-coverage.spec.ts

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -207,23 +207,27 @@ describe('a11y component test coverage', () => {
207207
function buildMissingTestsMessage(missingTests: string[]): string {
208208
if (missingTests.length === 0) return ''
209209
return (
210-
`Missing a11y tests for ${missingTests.length} component(s):\n${missingTests
211-
.map(c => ` - ${c}`)
212-
.join('\n')}\n\nTo fix: Add tests in test/nuxt/a11y.spec.ts or add to SKIPPED_COMPONENTS ` +
213-
`in test/unit/a11y-component-coverage.spec.ts with justification.`
210+
`Missing a11y tests for ${missingTests.length} component(s):\n` +
211+
missingTests.map(c => ` - ${c}`).join('\n') +
212+
'\n\nTo fix: Add tests in test/nuxt/a11y.spec.ts or add to SKIPPED_COMPONENTS ' +
213+
'in test/unit/a11y-component-coverage.spec.ts with justification.'
214214
)
215215
}
216216

217217
function buildObsoleteSkipsMessage(obsoleteSkips: string[]): string {
218218
if (obsoleteSkips.length === 0) return ''
219-
return `Obsolete SKIPPED_COMPONENTS entries:\n${obsoleteSkips
220-
.map(c => ` - ${c}`)
221-
.join('\n')}\n\nThese components no longer exist. Remove them from SKIPPED_COMPONENTS.`
219+
return (
220+
`Obsolete SKIPPED_COMPONENTS entries:\n` +
221+
obsoleteSkips.map(c => ` - ${c}`).join('\n') +
222+
'\n\nThese components no longer exist. Remove them from SKIPPED_COMPONENTS.'
223+
)
222224
}
223225

224226
function buildUnnecessarySkipsMessage(unnecessarySkips: string[]): string {
225227
if (unnecessarySkips.length === 0) return ''
226-
return `Unnecessary SKIPPED_COMPONENTS entries:\n${unnecessarySkips
227-
.map(c => ` - ${c}`)
228-
.join('\n')}\n\nThese components have tests now. Remove them from SKIPPED_COMPONENTS.`
228+
return (
229+
`Unnecessary SKIPPED_COMPONENTS entries:\n` +
230+
unnecessarySkips.map(c => ` - ${c}`).join('\n') +
231+
'\n\nThese components have tests now. Remove them from SKIPPED_COMPONENTS.'
232+
)
229233
}

0 commit comments

Comments
 (0)