Skip to content

Commit a3c0c50

Browse files
committed
fix: use consistent group-hover for deprecated version link colors
1 parent ba26fa6 commit a3c0c50

2 files changed

Lines changed: 12 additions & 10 deletions

File tree

app/components/Package/Versions.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ function majorGroupContainsCurrent(group: (typeof otherMajorGroups.value)[0]): b
614614
class="text-sm after:absolute after:inset-0 after:content-['']"
615615
:class="
616616
row.primaryVersion.deprecated
617-
? 'text-red-800 hover:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
617+
? 'text-red-800 group-hover/version-row:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
618618
: undefined
619619
"
620620
:title="
@@ -683,7 +683,7 @@ function majorGroupContainsCurrent(group: (typeof otherMajorGroups.value)[0]): b
683683
class="text-xs after:absolute after:inset-0 after:content-['']"
684684
:class="
685685
v.deprecated
686-
? 'text-red-800 hover:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
686+
? 'text-red-800 group-hover/version-row:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
687687
: undefined
688688
"
689689
:title="
@@ -795,7 +795,7 @@ function majorGroupContainsCurrent(group: (typeof otherMajorGroups.value)[0]): b
795795
class="text-xs after:absolute after:inset-0 after:content-['']"
796796
:class="
797797
row.primaryVersion.deprecated
798-
? 'text-red-800 hover:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
798+
? 'text-red-800 group-hover/version-row:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
799799
: undefined
800800
"
801801
:title="
@@ -882,7 +882,7 @@ function majorGroupContainsCurrent(group: (typeof otherMajorGroups.value)[0]): b
882882
class="text-xs after:absolute after:inset-0 after:content-['']"
883883
:class="
884884
group.versions[0]?.deprecated
885-
? 'text-red-800 hover:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
885+
? 'text-red-800 group-hover/version-row:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
886886
: undefined
887887
"
888888
:title="
@@ -949,7 +949,7 @@ function majorGroupContainsCurrent(group: (typeof otherMajorGroups.value)[0]): b
949949
class="text-xs ms-6 after:absolute after:inset-0 after:content-['']"
950950
:class="
951951
group.versions[0]?.deprecated
952-
? 'text-red-800 hover:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
952+
? 'text-red-800 group-hover/version-row:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
953953
: undefined
954954
"
955955
:title="
@@ -1021,7 +1021,7 @@ function majorGroupContainsCurrent(group: (typeof otherMajorGroups.value)[0]): b
10211021
class="text-xs after:absolute after:inset-0 after:content-['']"
10221022
:class="
10231023
v.deprecated
1024-
? 'text-red-800 hover:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
1024+
? 'text-red-800 group-hover/version-row:text-red-700 dark:text-red-400 dark:group-hover/version-row:text-red-300'
10251025
: undefined
10261026
"
10271027
:title="

test/nuxt/components/PackageVersions.spec.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ describe('PackageVersions', () => {
101101
expect(versionLinks[0]?.text()).toBe('1.0.0')
102102
})
103103

104-
it('highlights the current version row when currentVersion prop matches', async () => {
104+
it('highlights the current version row when selectedVersion prop matches', async () => {
105105
const component = await mountSuspended(PackageVersions, {
106106
props: {
107107
packageName: 'test-package',
@@ -114,11 +114,13 @@ describe('PackageVersions', () => {
114114
'2.0.0': '2024-01-15T12:00:00.000Z',
115115
'1.0.0': '2024-01-01T12:00:00.000Z',
116116
},
117-
currentVersion: '1.0.0',
117+
selectedVersion: '1.0.0',
118118
},
119119
})
120120

121-
const highlightedRows = component.findAll('.bg-bg-subtle')
121+
// Find the version row divs that are direct children of the tag row containers
122+
const versionRows = component.findAll('[class*="group/version-row"]')
123+
const highlightedRows = versionRows.filter(row => row.classes().includes('bg-bg-subtle'))
122124
expect(highlightedRows.length).toBe(1)
123125
expect(highlightedRows[0]!.text()).toContain('1.0.0')
124126
})
@@ -136,7 +138,7 @@ describe('PackageVersions', () => {
136138
'2.0.0': '2024-01-15T12:00:00.000Z',
137139
'1.0.0': '2024-01-01T12:00:00.000Z',
138140
},
139-
currentVersion: '1.0.0',
141+
selectedVersion: '1.0.0',
140142
},
141143
})
142144

0 commit comments

Comments
 (0)