Skip to content

Commit a549704

Browse files
committed
fix: don't rely on pkg.updated for update date
Fixes #535 It appears that the dates in `updated` field are not reliable at all (see #535 for details). Therefore I removed it and left only `package.date`, and now I get the exact results that I expected.
1 parent 8825b0a commit a549704

3 files changed

Lines changed: 5 additions & 8 deletions

File tree

app/components/PackageTableRow.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ const emit = defineEmits<{
1717
const pkg = computed(() => props.result.package)
1818
const score = computed(() => props.result.score)
1919
20-
// Get the best available date: prefer result.updated (from packument), fall back to package.date
21-
const updatedDate = computed(() => props.result.updated ?? props.result.package.date)
20+
const updatedDate = computed(() => props.result.package.date)
2221
2322
function formatDownloads(count?: number): string {
2423
if (count === undefined) return '-'

app/composables/useStructuredFilters.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ export function useStructuredFilters(options: UseStructuredFiltersOptions) {
225225
const config = UPDATED_WITHIN_OPTIONS.find(o => o.value === within)
226226
if (!config?.days) return true
227227

228-
const updatedDate = new Date(pkg.updated ?? pkg.package.date)
228+
const updatedDate = new Date(pkg.package.date)
229229
const cutoff = new Date()
230230
cutoff.setDate(cutoff.getDate() - config.days)
231231
return updatedDate >= cutoff
@@ -260,9 +260,7 @@ export function useStructuredFilters(options: UseStructuredFiltersOptions) {
260260
diff = (a.downloads?.weekly ?? 0) - (b.downloads?.weekly ?? 0)
261261
break
262262
case 'updated':
263-
diff =
264-
new Date(a.updated ?? a.package.date).getTime() -
265-
new Date(b.updated ?? b.package.date).getTime()
263+
diff = new Date(a.package.date).getTime() - new Date(b.package.date).getTime()
266264
break
267265
case 'name':
268266
diff = a.package.name.localeCompare(b.package.name)

app/pages/~[username]/index.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ const filteredAndSortedPackages = computed(() => {
106106
switch (sortOption.value) {
107107
case 'updated':
108108
pkgs.sort((a, b) => {
109-
const dateA = a.updated || a.package.date || ''
110-
const dateB = b.updated || b.package.date || ''
109+
const dateA = a.package.date || ''
110+
const dateB = b.package.date || ''
111111
return dateB.localeCompare(dateA)
112112
})
113113
break

0 commit comments

Comments
 (0)