Skip to content

Commit b01a764

Browse files
committed
fix: address brand page review feedback — sizing, wording, and layout
- Decrease container width to max-w-2xl to match other info pages - Increase font sizes from text-xs to text-sm (14px+) - Increase button sizes from sm to md for better touch targets - Update guidelines wording per alexdln's suggestion with Discord link
1 parent b015c8e commit b01a764

File tree

3 files changed

+27
-16
lines changed

3 files changed

+27
-16
lines changed

app/components/Brand/Customize.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ async function downloadCustomPng() {
144144
<!-- Accent color picker -->
145145
<fieldset class="flex items-center gap-3 flex-1 border-none p-0 m-0">
146146
<legend class="sr-only">{{ $t('brand.customize.accent_label') }}</legend>
147-
<span class="text-xs font-mono text-fg-muted shrink-0">{{
147+
<span class="text-sm font-mono text-fg-muted shrink-0">{{
148148
$t('brand.customize.accent_label')
149149
}}</span>
150150
<div class="flex items-center gap-1.5" role="radiogroup">
@@ -170,13 +170,13 @@ async function downloadCustomPng() {
170170

171171
<!-- Background toggle -->
172172
<div class="flex items-center gap-3">
173-
<span class="text-xs font-mono text-fg-muted">{{ $t('brand.customize.bg_label') }}</span>
173+
<span class="text-sm font-mono text-fg-muted">{{ $t('brand.customize.bg_label') }}</span>
174174
<div
175175
class="flex items-center border border-border rounded-md overflow-hidden"
176176
role="radiogroup"
177177
>
178178
<ButtonBase
179-
size="sm"
179+
size="md"
180180
role="radio"
181181
:aria-checked="customBgDark"
182182
:aria-label="$t('brand.logos.on_dark')"
@@ -189,7 +189,7 @@ async function downloadCustomPng() {
189189
{{ $t('brand.logos.on_dark') }}
190190
</ButtonBase>
191191
<ButtonBase
192-
size="sm"
192+
size="md"
193193
role="radio"
194194
:aria-checked="!customBgDark"
195195
:aria-label="$t('brand.logos.on_light')"
@@ -207,7 +207,7 @@ async function downloadCustomPng() {
207207
<!-- Download buttons -->
208208
<div class="flex items-center gap-2">
209209
<ButtonBase
210-
size="sm"
210+
size="md"
211211
:aria-label="$t('brand.customize.download_svg_aria')"
212212
:disabled="svgLoading"
213213
@click="downloadCustomSvg"
@@ -220,7 +220,7 @@ async function downloadCustomPng() {
220220
{{ $t('brand.logos.download_svg') }}
221221
</ButtonBase>
222222
<ButtonBase
223-
size="sm"
223+
size="md"
224224
:aria-label="$t('brand.customize.download_png_aria')"
225225
:disabled="pngLoading"
226226
@click="downloadCustomPng"

app/pages/brand.vue

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script setup lang="ts">
2-
import { ACCENT_COLORS } from '#shared/utils/constants'
2+
import { ACCENT_COLORS, DISCORD_COMMUNITY_URL } from '#shared/utils/constants'
33
44
useSeoMeta({
55
title: () => `${$t('brand.title')} - npmx`,
@@ -69,7 +69,7 @@ async function handlePngDownload(logo: (typeof logos)[number]) {
6969

7070
<template>
7171
<main class="container flex-1 py-12 sm:py-16 overflow-x-hidden">
72-
<article class="max-w-4xl mx-auto">
72+
<article class="max-w-2xl mx-auto">
7373
<!-- Header -->
7474
<header class="mb-12">
7575
<div class="flex items-baseline justify-between gap-4 mb-4">
@@ -119,12 +119,12 @@ async function handlePngDownload(logo: (typeof logos)[number]) {
119119
/>
120120
</div>
121121
<div class="flex items-center justify-between mt-2">
122-
<span class="text-xs text-fg-subtle font-mono">{{
122+
<span class="text-sm text-fg-subtle font-mono">{{
123123
$t('brand.logos.on_dark')
124124
}}</span>
125125
<div class="flex items-center gap-2">
126126
<ButtonBase
127-
size="sm"
127+
size="md"
128128
:aria-label="
129129
$t('brand.logos.download_svg_aria', {
130130
name: `${logo.name()} (${$t('brand.logos.on_dark')})`,
@@ -145,7 +145,7 @@ async function handlePngDownload(logo: (typeof logos)[number]) {
145145
{{ $t('brand.logos.download_svg') }}
146146
</ButtonBase>
147147
<ButtonBase
148-
size="sm"
148+
size="md"
149149
:aria-label="
150150
$t('brand.logos.download_png_aria', {
151151
name: `${logo.name()} (${$t('brand.logos.on_dark')})`,
@@ -189,12 +189,12 @@ async function handlePngDownload(logo: (typeof logos)[number]) {
189189
/>
190190
</div>
191191
<div class="flex items-center justify-between mt-2">
192-
<span class="text-xs text-fg-subtle font-mono">{{
192+
<span class="text-sm text-fg-subtle font-mono">{{
193193
$t('brand.logos.on_light')
194194
}}</span>
195195
<div class="flex items-center gap-2">
196196
<ButtonBase
197-
size="sm"
197+
size="md"
198198
:aria-label="
199199
$t('brand.logos.download_svg_aria', {
200200
name: `${logo.name()} (${$t('brand.logos.on_light')})`,
@@ -215,7 +215,7 @@ async function handlePngDownload(logo: (typeof logos)[number]) {
215215
{{ $t('brand.logos.download_svg') }}
216216
</ButtonBase>
217217
<ButtonBase
218-
size="sm"
218+
size="md"
219219
:aria-label="
220220
$t('brand.logos.download_png_aria', {
221221
name: `${logo.name()} (${$t('brand.logos.on_light')})`,
@@ -314,7 +314,17 @@ async function handlePngDownload(logo: (typeof logos)[number]) {
314314
<blockquote
315315
class="border-is-2 border-is-accent ps-6 py-2 text-fg-muted leading-relaxed italic"
316316
>
317-
{{ $t('brand.guidelines.message') }}
317+
<i18n-t keypath="brand.guidelines.message" tag="p" class="m-0">
318+
<template #link>
319+
<a
320+
:href="DISCORD_COMMUNITY_URL"
321+
target="_blank"
322+
rel="noopener noreferrer"
323+
class="text-accent hover:underline"
324+
>{{ $t('brand.guidelines.discord_link_text') }}</a
325+
>
326+
</template>
327+
</i18n-t>
318328
</blockquote>
319329
</section>
320330
</div>

i18n/locales/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1521,7 +1521,8 @@
15211521
},
15221522
"guidelines": {
15231523
"title": "just a note",
1524-
"message": "When using the npmx logo, we kindly ask that you keep it legible — ensure there's enough contrast against the background and don't go smaller than 24px. Accessibility matters to us, and we appreciate you keeping that in mind."
1524+
"message": "Accessibility matters to us, and we would love you to follow us in this vision. When using mentioned media, ensure there is enough contrast against the background, and don't go smaller than 24px. If you need any other resources or additional information about the project, feel free to reach us at {link}.",
1525+
"discord_link_text": "chat.npmx.dev"
15251526
}
15261527
}
15271528
}

0 commit comments

Comments
 (0)